Many (most?) google results point to pages with missing images/css

Bug #1288513 reported by Lars Kellogg-Stedman
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
openstack-manuals
Fix Released
High
Lars Kellogg-Stedman

Bug Description

Many searches seem to hit pages in the Grizzly network admin guide at http://docs.openstack.org/grizzly/openstack-network/admin/content/. All the results in Google include a double slash after "content/", for example:

  http://docs.openstack.org/grizzly/openstack-network/admin/content//adv_cfg_l3_agent_multi_extnet.html

This results in a variety of problems (no images, no css, etc). Just handling this one case would make a number of pages display correctly. It seems like some sort of rewriterule with a 301 ("moved permanently") redirect would solve all of this.

Revision history for this message
Lars Kellogg-Stedman (larsks) wrote :

For example, this Google search:

  https://www.google.com/search?q=nova+live+migration

The first four results all suffer from this problem.

Changed in openstack-manuals:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Anne Gentle (annegentle) wrote :

First attempt to fix this was at https://review.openstack.org/#/c/71673/2/www/.htaccess

What additional redirects are needed?

Revision history for this message
Lars Kellogg-Stedman (larsks) wrote :

As discussed on irc, what we need is essentially:

  rewriterule (.*)//(.*) $1/$2 [R=301]

This would take any request containing "//", rewrite it with a single "/", and issue a 301 redirect to the new URL. This should eventually cause Google to update its index as well.

Revision history for this message
Anne Gentle (annegentle) wrote :

Found this in one of the problematic pages:

<link rel="canonical" href="http://docs.openstack.org/trunk/config-reference/content//configuring-openstack-compute-basics.html"/>

I think the doc tool is outputting incorrect canonoical URLs.

Fix should lie in the clouddocs-maven-plugin. In the mean time, though we could try patching pom.xml so that it doesn't have <canonicalUrl> settings in it.

Changed in openstack-manuals:
status: Confirmed → Triaged
tags: added: doc-builds doc-tools
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-manuals (master)

Fix proposed to branch: master
Review: https://review.openstack.org/78505

Changed in openstack-manuals:
assignee: nobody → Anne Gentle (annegentle)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-manuals (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/78508

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-manuals (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/78509

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-manuals (master)

Reviewed: https://review.openstack.org/78505
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=4555b0edadeee56360852391c7a9ee5dd8ae4653
Submitter: Jenkins
Branch: master

commit 4555b0edadeee56360852391c7a9ee5dd8ae4653
Author: Anne Gentle <email address hidden>
Date: Wed Mar 5 21:09:07 2014 -0600

    All these pom.xml files were causing an incorrect canonical url

    Change-Id: I5f5ce9f0e4bf2e9541143f2a76b6a145d8794b2e
    Partial-bug: 1288513

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-manuals (stable/havana)

Reviewed: https://review.openstack.org/78509
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=6e9d3a5ab4eae8cf9b14362e8449211ce78f3e38
Submitter: Jenkins
Branch: stable/havana

commit 6e9d3a5ab4eae8cf9b14362e8449211ce78f3e38
Author: Anne Gentle <email address hidden>
Date: Wed Mar 5 21:18:14 2014 -0600

    For Havana, these pom.xml files were causing an incorrect canonical url

    Change-Id: Id952f146204feeeb732ac7f50e313fd96298a2cb
    Partial-bug: 1288513

tags: added: in-stable-havana
Changed in openstack-manuals:
assignee: Anne Gentle (annegentle) → Lars Kellogg-Stedman (larsks)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-manuals (master)

Fix proposed to branch: master
Review: https://review.openstack.org/78518

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-manuals (stable/grizzly)

Reviewed: https://review.openstack.org/78508
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=251f691aee98589591721c2c0fa1e3d2d8ecfa73
Submitter: Jenkins
Branch: stable/grizzly

commit 251f691aee98589591721c2c0fa1e3d2d8ecfa73
Author: Anne Gentle <email address hidden>
Date: Wed Mar 5 21:15:29 2014 -0600

    For grizzly, these pom.xml files were causing incorrect canonical url

    Change-Id: I035198446a433305f951a9e520c461cc6bc47da5
    Partial-bug: 1288513

tags: added: in-stable-grizzly
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-manuals (master)

Reviewed: https://review.openstack.org/78518
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=27802f81f4b0ebb7eeee385e5c8071b10ddd4683
Submitter: Jenkins
Branch: master

commit 27802f81f4b0ebb7eeee385e5c8071b10ddd4683
Author: Lars Kellogg-Stedman <email address hidden>
Date: Wed Mar 5 23:38:14 2014 -0500

    correctly handle doc urls containing "//"

    A doc generation bug resulted in Google indexing links containing "//", which cause
    problems with linked content (images/css/etc). This rule generates a 301 redirect
    for these links.

    Change-Id: Iff1e73e0f3db80c11a56a08abd67dd6c050c1aa1
    Partial-bug: 1288513

Changed in openstack-manuals:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.