autohelp tool does not extract vmware flags in cinder

Bug #1240804 reported by Kartik Bommepally on 2013-10-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-manuals
High
Unassigned

Bug Description

Cinder has a new driver for vmware.
When trying to auto generate doc tables for the driver configuration, the following is observed:
<<
root@ubuntu:~/work/openstack-manuals/tools/autogenerate-config-docs# ./autohelp.py --action update -i flagmappings/cinder.flagmappings -o names --path /root/work/cinder1/cinder/
367 flags imported from package cinder.

Removed Flags

Added Flags

nexenta_nms_cache_volroot
volume_service_inithost_offload
>>

The vmware specific flags are not being extracted by the tool.
When run in verbose, logs says it "imported cinder.volume.drivers.vmware..."

Changed in openstack-manuals:
status: New → Confirmed
importance: Undecided → High
Tom Fifield (fifieldt) wrote :

Hi,

This is because the options are only registered after module instantiation.

This tool works by importing the module and relying on that to update the global configuration.

114 def __init__(self, *args, **kwargs):
115 super(VMwareEsxVmdkDriver, self).__init__(*args, **kwargs)
116 self.configuration.append_config_values(vmdk_opts)

If you take a look at other drivers, you'll see that they register opts in the global space, eg

 42 CONF = cfg.CONF
 43 CONF.register_opts(huawei_opt)

Verified, raised a separate bug https://bugs.launchpad.net/cinder/+bug/1242547

Changed in openstack-manuals:
status: Confirmed → Invalid
tags: added: drivers vmdk
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers