Stop and delete operations should give guest a chance to shutdown

Bug #1204566 reported by OpenStack Infra on 2013-07-24
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-manuals
Medium
Olga Gusarenko

Bug Description

https://review.openstack.org/35303
commit abca73c23942c4533449dff2242dd8314e9879f4
Author: Phil Day <email address hidden>
Date: Tue Jul 2 15:32:57 2013 +0100

    Stop and delete operations should give guest a chance to shutdown

    Currently in libvirt stop and delete operations simply destroy the
    underlying VM. Some GuestOS's do not react well to this type of
    power failure, and so it would be better if these operations
    followed the same approach as soft_reboot and give the guest as
    chance to shutdown gracefully. Even where VM is being deleted,
    it may be booted from a volume which will be reused on another
    server.

    The change is implemented by adding a clean_shutdown parameter
    to delete and stop methods from the compute/api layer downwards
    and into the virt drivers. The implementation in the libvirt
    driver is also provided. Other drivers are modified just to
    expect the additional parameter.

    The timer configuration value previous used by soft_reboot in
    libvirt is moved up to virt/driver so it can be used by other drivers.

    A separate config value defines what the default shutdown
    behaviour for delete should be (default False to keep compatibility
    with current behaviour).

    This code enables a subsequent API change to add add clean/forced
    options to the stop and delete methods

    Fixes bug 1196924

    DocImpact

    Change-Id: Ie69aa2621cb52d6fefdc19f664247b069d6782ee

Tom Fifield (fifieldt) on 2013-07-25
Changed in openstack-manuals:
milestone: none → havana
Anne Gentle (annegentle) on 2013-09-17
Changed in openstack-manuals:
status: New → Confirmed
importance: Undecided → Medium
tags: added: release-notes
Tom Fifield (fifieldt) on 2013-12-20
tags: added: autogen
Tom Fifield (fifieldt) on 2014-06-25
Changed in openstack-manuals:
milestone: havana → juno
Tom Fifield (fifieldt) on 2014-09-09
tags: added: autogenerate-config-docs
removed: autogen
Tom Fifield (fifieldt) on 2015-01-06
Changed in openstack-manuals:
milestone: juno → kilo
Changed in openstack-manuals:
assignee: nobody → Olga Gusarenko (ogusarenko)
Olga Gusarenko (ogusarenko) wrote :

Hi, everyone!

I have a question regarding the list of operations which give the GuestOS a chance to shutdown. I am not sure about "delete", as it is not in the spec.

Could anyone please clarify wether the following list is complete:
- nova stop [–hard-shutdown]
- nova rescue [–hard-shutdown]
- nova resize [–hard-shutdown]
- nova shelve [–hard-shutdown]

Thanks in advance!

Tom Fifield (fifieldt) on 2015-05-01
Changed in openstack-manuals:
milestone: kilo → liberty
Lana (loquacity) wrote :

Hi Olga, why not reach out to the Nova liaisons to get help on this one? I've added Michael Still and Joe Gordon to the bug, but feel free to email them :)

https://wiki.openstack.org/wiki/CrossProjectLiaisons#Documentation

Fix proposed to branch: master
Review: https://review.openstack.org/203581

Changed in openstack-manuals:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/203581
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=c263b5daa854a59ac36a692123867347cd7b903b
Submitter: Jenkins
Branch: master

commit c263b5daa854a59ac36a692123867347cd7b903b
Author: OlgaGusarenko <email address hidden>
Date: Mon Jul 20 13:51:41 2015 +0300

    Controlled shutdown for rescue, shelve, and resize

    Rescue, shelve, and resize operations now give the guest OS
    a chance to shutdown cleanly before powering off the VM.

    The shutdown behavior is defined by the shutdown_timeout
    conf parameter

    Change-Id: I45699daaf1ed4b5e800f80563cd23f9befd5bb45
    Partial-bug: 1204566

Lana (loquacity) on 2015-09-03
Changed in openstack-manuals:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers