RSS feed is not available when no failures in jobs listing

[Emilien Macchi]

The get_recent_failed_runs_rss method is returning none if no failure.
The problem is that if nothing is return the RSS feed is not available, see:
http://health.openstack.org/runs/key/build_name/periodic-puppet-openstack-integration-4-scenario001-tempest-ubuntu-trusty/recent/rss

"No Failed Runs for run metadata build_name: periodic-puppet-openstack-integration-4-scenario001-tempest-ubuntu-trusty"

We would need to have something returned anyway (an empty feed), so RSS client don't fail to add the feed.

[Matthew Treinish (treinish)]

The tricky bit here is verifying between a valid key value pair and a key value pair that simply has no failures. The subunit2sql DB in both cases returns an empty list so by itself you can't differentiate. We want to make sure we return a 4xx response on the invalid case. I'm thinking the way forward here is to simply add an additional key, value lookup call when there is an empty list. If the key is valid return an empty feed, else return 4xx.

[Masayuki Igawa (igawa)]

I added this as a storyboard story.
https://storyboard.openstack.org/#!/story/2000614

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/323233

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/323233
Committed: https://git.openstack.org/cgit/openstack/openstack-health/commit/?id=8d9eb1da5dc333d7a93d68857aa72dbdf120ac98
Submitter: Jenkins
Branch: master

commit 8d9eb1da5dc333d7a93d68857aa72dbdf120ac98
Author: Masayuki Igawa <email address hidden>
Date: Tue May 31 17:53:57 2016 +0900

    Fix RSS feed unavailable when no failure

    This commit fixes RSS feed unavailable error to return zero length entry
    list when there is specified run_metadata_key and value with no failure.

    Closes-Bug: #1573630
    Change-Id: I48659140314a2d8737611dd0a86097f10c1f3ac8