Sharable links include all sorts of extra unused params
Bug #1572766 reported by
Matthew Treinish
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Health |
Fix Released
|
Undecided
|
Tim Buckley |
Bug Description
When navigating between pages on openstack-health the params you set on previous pages are sticky in the url and transfer between consecutive view. In other words if you set a groupkey param on the home page but then change to the second page view or the tests page the groupkey parameter is still in the url and it doesn't mean anything except on the first page. When you jump around between a couple of pages the urls can get kinda lengthy for no reason.
To post a comment you must log in.
There's a couple things we can do to clean this up:
- Controllers should listen for $destroy events and remove any page-specific parameters like 'search', 'limit', 'offset', etc (this is an issue for tests detail pagination)
- Parameters at their default values shouldn't be shown in the URL at all (e.g. resolutionKey=hour, groupKey=project, etc should only be included if explicitly changed). The 'end' parameter could probably also be left out though after a period of time it would stop showing the same data.
I'll look into implementing these.