Pagination breaks links on tests view

Bug #1572763 reported by Matthew Treinish
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Health
In Progress
High
Tim Buckley

Bug Description

The pagination feature is really weird on the tests view when combined with search filtering. The filtering seems to be applied second which means it's only filtering for the page you're looking at. This is kinda un-intuitive especially when sharing links because it'll filter away everything you're looking at and you have to change pages to see what you're supposed to be looking at. For example:

http://status.openstack.org/openstack-health/#/tests/tempest?groupKey=project&resolutionKey=hour&end=2016-04-20T22:08:31.474Z&searchTest=tempest.api.volume.v2.test_volumes_list.VolumesV2ListTestJSON.test_volume_list_with_detail_param_marker

Revision history for this message
Tim Buckley (timothy-jas-buckley) wrote :

I think the first thing needed to fix this is to add 'offset' to the URL parameters. Long-term I think we should look into moving filtering server-side so it actually works as expected in general, since this is really only one possible source of confusion.

Changed in openstack-health:
assignee: nobody → Tim Buckley (timothy-jas-buckley)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-health (master)

Fix proposed to branch: master
Review: https://review.openstack.org/308734

Changed in openstack-health:
status: New → In Progress
Changed in openstack-health:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-health (master)

Reviewed: https://review.openstack.org/308734
Committed: https://git.openstack.org/cgit/openstack/openstack-health/commit/?id=9300b8a87c51183e4940300113ea1a5bcb695958
Submitter: Jenkins
Branch: master

commit 9300b8a87c51183e4940300113ea1a5bcb695958
Author: Tim Buckley <email address hidden>
Date: Wed Apr 20 21:58:21 2016 -0600

    Add 'offset' parameter to URL on tests detail page

    This adds an 'offset' parameter to the URL on the tests detail page,
    so that state is correctly saved in shared URLs.

    Change-Id: I05fe38d45e4c88115514b3f0aca77705404bc991
    Partial-Bug: 1572763

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.