mock fails with SyntaxError in py26

Bug #1473286 reported by Pete Zaitcev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Gate
Invalid
Undecided
Unassigned

Bug Description

We might have installed a mock in the gate that is incompatible with py26.

Original log:
 http://logs.openstack.org/71/200371/1/check/gate-git-review-python26/c51537e/console.html

Except:

2015-07-10 04:33:46.521 | + tox -v -epy26
2015-07-10 04:33:46.741 | using tox.ini: /home/jenkins/workspace/gate-git-review-python26/tox.ini
2015-07-10 04:33:46.741 | using tox-2.1.1 from /usr/lib/python2.6/site-packages/tox/__init__.pyc
2015-07-10 04:33:46.742 | GLOB sdist-make: /home/jenkins/workspace/gate-git-review-python26/setup.py
2015-07-10 04:33:46.752 | /home/jenkins/workspace/gate-git-review-python26$ /usr/bin/python /home/jenkins/workspace/gate-git-review-python26/setup.py sdist --formats=zip --dist-dir /home/jenkins/workspace/gate-git-review-python26/.tox/dist >/home/jenkins/workspace/gate-git-review-python26/.tox/log/tox-0.log
2015-07-10 04:33:47.609 | py26 create: /home/jenkins/workspace/gate-git-review-python26/.tox/py26
2015-07-10 04:33:47.623 | /home/jenkins/workspace/gate-git-review-python26/.tox$ /usr/bin/python -m virtualenv --python /usr/bin/python2.6 py26 >/home/jenkins/workspace/gate-git-review-python26/.tox/py26/log/py26-0.log
2015-07-10 04:33:49.472 | py26 installdeps: -r/home/jenkins/workspace/gate-git-review-python26/requirements.txt, -r/home/jenkins/workspace/gate-git-review-python26/test-requirements.txt
2015-07-10 04:33:49.473 | /home/jenkins/workspace/gate-git-review-python26$ /home/jenkins/workspace/gate-git-review-python26/.tox/py26/bin/pip install -U -r/home/jenkins/workspace/gate-git-review-python26/requirements.txt -r/home/jenkins/workspace/gate-git-review-python26/test-requirements.txt >/home/jenkins/workspace/gate-git-review-python26/.tox/py26/log/py26-1.log
2015-07-10 04:34:00.088 | py26 inst: /home/jenkins/workspace/gate-git-review-python26/.tox/dist/git-review-1.25.1.dev8.zip
2015-07-10 04:34:00.089 | /home/jenkins/workspace/gate-git-review-python26$ /home/jenkins/workspace/gate-git-review-python26/.tox/py26/bin/pip install -U /home/jenkins/workspace/gate-git-review-python26/.tox/dist/git-review-1.25.1.dev8.zip >/home/jenkins/workspace/gate-git-review-python26/.tox/py26/log/py26-2.log
2015-07-10 04:34:02.025 | py26 installed: argparse==1.3.0,discover==0.4.0,docutils==0.12,extras==0.0.3,fixtures==1.3.1,flake8==2.2.4,funcsigs==0.4,git-review==1.25.1.dev8,hacking==0.10.2,Jinja2==2.7.3,linecache2==1.0.0,MarkupSafe==0.23,mccabe==0.2.1,mock==1.1.0,oslosphinx==3.0.0,pbr==1.2.0,pep8==1.5.7,pyflakes==0.8.1,Pygments==2.0.2,python-mimeparse==0.1.4,python-subunit==1.1.0,requests==2.7.0,six==1.9.0,Sphinx==1.2.3,testrepository==0.0.20,testtools==1.8.0,traceback2==1.4.0,unittest2==1.1.0,wheel==0.24.0
2015-07-10 04:34:02.026 | py26 runtests: PYTHONHASHSEED='2585212730'
2015-07-10 04:34:02.026 | py26 runtests: commands[0] | python -m git_review.tests.prepare
2015-07-10 04:34:02.027 | /home/jenkins/workspace/gate-git-review-python26$ /home/jenkins/workspace/gate-git-review-python26/.tox/py26/bin/python -m git_review.tests.prepare
2015-07-10 04:34:02.179 | Traceback (most recent call last):
2015-07-10 04:34:02.179 | File "/usr/lib64/python2.6/runpy.py", line 104, in _run_module_as_main
2015-07-10 04:34:02.180 | loader, code, fname = _get_module_details(mod_name)
2015-07-10 04:34:02.180 | File "/usr/lib64/python2.6/runpy.py", line 79, in _get_module_details
2015-07-10 04:34:02.181 | loader = get_loader(mod_name)
2015-07-10 04:34:02.181 | File "/usr/lib64/python2.6/pkgutil.py", line 456, in get_loader
2015-07-10 04:34:02.212 | return find_loader(fullname)
2015-07-10 04:34:02.213 | File "/usr/lib64/python2.6/pkgutil.py", line 466, in find_loader
2015-07-10 04:34:02.213 | for importer in iter_importers(fullname):
2015-07-10 04:34:02.213 | File "/usr/lib64/python2.6/pkgutil.py", line 422, in iter_importers
2015-07-10 04:34:02.213 | __import__(pkg)
2015-07-10 04:34:02.213 | File "git_review/tests/__init__.py", line 30, in <module>
2015-07-10 04:34:02.214 | import fixtures
2015-07-10 04:34:02.214 | File "/home/jenkins/workspace/gate-git-review-python26/.tox/py26/lib/python2.6/site-packages/fixtures/__init__.py", line 87, in <module>
2015-07-10 04:34:02.214 | from fixtures._fixtures import (
2015-07-10 04:34:02.214 | File "/home/jenkins/workspace/gate-git-review-python26/.tox/py26/lib/python2.6/site-packages/fixtures/_fixtures/__init__.py", line 55, in <module>
2015-07-10 04:34:02.215 | from fixtures._fixtures.mockpatch import (
2015-07-10 04:34:02.215 | File "/home/jenkins/workspace/gate-git-review-python26/.tox/py26/lib/python2.6/site-packages/fixtures/_fixtures/mockpatch.py", line 22, in <module>
2015-07-10 04:34:02.215 | mock = extras.try_imports(['unittest.mock', 'mock'], None)
2015-07-10 04:34:02.215 | File "/home/jenkins/workspace/gate-git-review-python26/.tox/py26/lib/python2.6/site-packages/extras/__init__.py", line 87, in try_imports
2015-07-10 04:34:02.215 | module = try_import(module_name, error_callback=error_callback)
2015-07-10 04:34:02.215 | File "/home/jenkins/workspace/gate-git-review-python26/.tox/py26/lib/python2.6/site-packages/extras/__init__.py", line 46, in try_import
2015-07-10 04:34:02.216 | module = __import__(module_name)
2015-07-10 04:34:02.216 | File "/home/jenkins/workspace/gate-git-review-python26/.tox/py26/lib/python2.6/site-packages/mock/__init__.py", line 2, in <module>
2015-07-10 04:34:02.216 | import mock.mock as _mock
2015-07-10 04:34:02.216 | File "/home/jenkins/workspace/gate-git-review-python26/.tox/py26/lib/python2.6/site-packages/mock/mock.py", line 132
2015-07-10 04:34:02.217 | _builtins = {name for name in dir(builtins) if not name.startswith('_')}
2015-07-10 04:34:02.218 | ^
2015-07-10 04:34:02.218 | SyntaxError: invalid syntax
2015-07-10 04:34:02.219 | ERROR: InvocationError: '/home/jenkins/workspace/gate-git-review-python26/.tox/py26/bin/python -m git_review.tests.prepare'
2015-07-10 04:34:02.219 | ___________________________________ summary ____________________________________
2015-07-10 04:34:02.219 | ERROR: py26: commands failed

Revision history for this message
Pete Zaitcev (zaitcev) wrote :

See the fix for swiftclient:
https://github.com/openstack/python-swiftclient/commit/87c0a839888123c8a1b5d0ec061e244bfc3e044c

But basic syntax in requirements.txt is this:

mock>=1.0;python_version!='2.6'
mock==1.0.1;python_version=='2.6'

Pete Zaitcev (zaitcev)
Changed in openstack-gate:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.