check-grenade-dsvm fails with [ERROR] /opt/stack/new/grenade/inc/plugin:Failed to die /opt/stack/new/devstack/functions-common

[Jay Bryant]

I saw this error on a check-grenade-dsvm run for a change that just changed a help text message:

2015-05-19 15:35:06.218 | [ERROR] /opt/stack/new/grenade/inc/plugin:Failed to
2015-05-19 15:35:07.221 | 1 die /opt/stack/new/devstack/functions-common

[Tom Barron (tpb)]

This is happening repeatedly for https://review.openstack.org/#/c/184154/, which changes only a help string. Note that this is a kilo backport.

[Jay Bryant (jsbryant)]

Thinking this may be the actual case of the failure:

/opt/stack/old/devstack/lib/keystone: line 569: disable_apache_site: command not found

Seeing this in another patch as well: https://review.openstack.org/#/c/184827

[Thai Tran (tqtran)]

Seeing the same thing on https://review.openstack.org/#/c/184865/ simple javascript backport

[Markus Zoeller (markus_z) (mzoeller)]

Same symptom on https://review.openstack.org/#/c/184240

[Stephen Ma (stephen-ma)]

My kilo backport https://review.openstack.org/#/c/177825 has the same failure in check-grenade-dsvm-neutron.

[Matt Riedemann (mriedem)]

Yes it's a thing, started on ~5/18:

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiL29wdC9zdGFjay9vbGQvZGV2c3RhY2svbGliL2tleXN0b25lXCIgQU5EIG1lc3NhZ2U6XCJkaXNhYmxlX2FwYWNoZV9zaXRlOiBjb21tYW5kIG5vdCBmb3VuZFwiIiwiZmllbGRzIjpbXSwib2Zmc2V0IjowLCJ0aW1lZnJhbWUiOiI2MDQ4MDAiLCJncmFwaG1vZGUiOiJjb3VudCIsInRpbWUiOnsidXNlcl9pbnRlcnZhbCI6MH0sInN0YW1wIjoxNDMyMzEyOTA0NjU4fQ==

Did something merge in stable/kilo or stable/juno (since this is grenade on stable/kilo changes, so old side is juno) in devstack or keystone?

[Matt Riedemann (mriedem)]

It was this: https://review.openstack.org/#/c/175531/

[Matt Riedemann (mriedem)]

Revert: https://review.openstack.org/#/c/185073/

[Matt Riedemann (mriedem)]

(9:54:00 AM) clarkb: mriedem: oh I see, the comment about not being able to upgrade is likely at fault, since we disable it in juno but don't do so in kilo

(9:56:51 AM) clarkb: mriedem: ya in the old code it always set wsgi off so we could do not wsgi to not wsgi upgrades, with that change it would be not wsig + juno to wsgi + kilo and that fails

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/190581

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/190597

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/190581

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/190597
Committed: https://git.openstack.org/cgit/openstack-dev/grenade/commit/?id=67b0ae46d65fd272574821a6c1b77ab811b12101
Submitter: Jenkins
Branch: stable/kilo

commit 67b0ae46d65fd272574821a6c1b77ab811b12101
Author: Sean Dague <email address hidden>
Date: Tue Apr 21 08:08:51 2015 -0400

    support apache based upgrades for keystone

    The following changes are needed for apache based keystone to upgrade

    - add lib/apache to keystone shutdown
    - don't check for screen logs for keystone after upgrade

    Closes-Bug: #1456835

    Depends-On: Ic9174f6f959f95eabf76ba8b8a19729898194a61
    (devstack-gate change to revert to old correct behavior)

    Change-Id: I8bc9d1362df95eba6436bd5f564001fe8b750386
    (cherry picked from commit cf655ee07891dcd5abe3b01e2b2f716038aa8792)