openstackdocstheme doesn't activate scripts
Bug #1798002 reported by
Tony Breeds
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| openstackdocstheme |
Fix Released
|
Undecided
|
Tony Breeds | ||
Bug Description
When trying to convert the election repo, which uses javascript, to openstackdocstheme we noticed that the javascript sources are added to _static but they're never referenced in a <script></script> element.
| Changed in openstack-doc-tools: | |
| assignee: | nobody → Tony Breeds (o-tony) |
| status: | New → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to openstackdocstheme (master) | #1 |
| Changed in openstack-doc-tools: | |
| status: | In Progress → Fix Released |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix included in openstack/openstackdocstheme 1.26.0 | #2 |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 3c5947dd995c66e
Author: Tony Breeds <email address hidden>
Date: Thu Oct 11 11:34:42 2018 +1100
Add scripts to the head section
For consumers that also call the add_javascript() function scripts are
added to the _static folder but not loaded in the HTML resulting in them
not working.
This change iterates over the script_files lists and adds the needed
<script>
Closes-Bug: 1798002
Needed-By: https:/
Change-Id: Ie39e138314fed9