no red for double backtick markups

Bug #1718256 reported by Ruby Loo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstackdocstheme
Fix Released
Undecided
Ruby Loo

Bug Description

The colour red has different connotations, it can be (in North America) associated with danger, error, warning. We shouldn't use red to highlight terms -- anything that is marked up with `` (double backticks) [1].

There was a short email discussion about this, no one mentioned that they wanted the red [2].

I think a monospace font, bolded, would be sufficient. I don't think we need it to be a different colour from the surrounding text.

[1] https://docs.openstack.org/contributor-guide/rst-conv/inline-markups.html
[2] http://lists.openstack.org/pipermail/openstack-dev/2017-August/121414.html

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstackdocstheme (master)

Fix proposed to branch: master
Review: https://review.openstack.org/505348

Changed in openstack-doc-tools:
assignee: nobody → Ruby Loo (rloo)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstackdocstheme (master)

Reviewed: https://review.openstack.org/505348
Committed: https://git.openstack.org/cgit/openstack/openstackdocstheme/commit/?id=e99cf6d96c0c79805ad2c155948e55d89704ce90
Submitter: Jenkins
Branch: master

commit e99cf6d96c0c79805ad2c155948e55d89704ce90
Author: Ruby Loo <email address hidden>
Date: Tue Sep 19 13:44:28 2017 -0400

    No red with double backticks markup

    The double backticks (``) markup caused text to be displayed in
    red with a pinkish background colour. The text is now displayed
    in black and bold, the same size as the surrounding text.

    Change-Id: Id73e828b69445aa9bf4c48bea84dd95fef16bc2b
    Fixes-Bug: 1718256

Changed in openstack-doc-tools:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.