CDN should be optional for docs builds

Bug #1523521 reported by Anne Gentle
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstackdocstheme
In Progress
High
Ryan Selden

Bug Description

CDN is not useful for local browsing (and may actually be a detriment). This can be enabled as a build-time job, similar to the Google Analytics option merged here: https://review.openstack.org/#/c/253592/

Anne Gentle (annegentle)
tags: added: doc-builds
tags: added: openstackdocstheme
Vishal (vishaldhanopia)
Changed in openstack-manuals:
assignee: nobody → Mark (rocky-asdf)
Changed in openstack-manuals:
assignee: Mark (rocky-asdf) → nobody
milestone: none → newton
Revision history for this message
Ryan Selden (ryanx-seldon) wrote :

Anne,

Would you recommend the build download the CDN files if the option is set to local browsing? I would assume by CDN files, you mean any bootstrap, google fonts, and fontawesome etc files, right?

Thanks
Ryan

Changed in openstack-manuals:
assignee: nobody → Ryan Selden (ryanx-seldon)
Revision history for this message
Anne Gentle (annegentle) wrote :

Hi Ryan,

I do think that downloading the files to serve locally meets the needs of an "offline browsing/building the docs" scenario.

Yeah, I think any files served on maxcdn like this line:

<link href="http://maxcdn.bootstrapcdn.com/font-awesome/4.2.0/css/font-awesome.css" rel="stylesheet">

Are what we're looking to bring local as an option.

Thanks,
Anne

Revision history for this message
Ryan Selden (ryanx-seldon) wrote :

Anne,

One even simpler option is to remove the use of a CDN anywhere - we discussed this in https://launchpad.net/bugs/1502806 - and my patch https://review.openstack.org/#/c/333573/ addresses it except for the google fonts include. I could update to include that - what are your thoughts?

Thanks
Ryan

Revision history for this message
Anne Gentle (annegentle) wrote :

Yeah that is probably fine -- though I did ask if we have any way to test the difference?

Revision history for this message
Ryan Selden (ryanx-seldon) wrote :

Not sure what you mean?

Revision history for this message
Anne Gentle (annegentle) wrote :

Oh maybe performance won't matter since Non-CDN is only when served locally?

Revision history for this message
Ryan Selden (ryanx-seldon) wrote :

Added another patch for removing CDN from OpenSans googlefont and IE compatibility scripts.

See https://review.openstack.org/#/c/339747

Changed in openstack-manuals:
milestone: newton → ocata
Changed in openstack-manuals:
status: Confirmed → In Progress
Revision history for this message
Alexandra Settle (alexandra-settle) wrote :

What's the update on these patches?

Brian Moss (bmoss)
affects: openstack-manuals → openstack-doc-tools
Changed in openstack-doc-tools:
milestone: ocata → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on openstackdocstheme (master)

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: master
Review: https://review.openstack.org/339747
Reason: Stale review - let's abandon.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.