CDN should be optional for docs builds

Bug #1523521 reported by Anne Gentle on 2015-12-07
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-doc-tools
High
Ryan Selden

Bug Description

CDN is not useful for local browsing (and may actually be a detriment). This can be enabled as a build-time job, similar to the Google Analytics option merged here: https://review.openstack.org/#/c/253592/

Anne Gentle (annegentle) on 2015-12-07
tags: added: doc-builds
tags: added: openstackdocstheme
Vishal (vishaldhanopia) on 2016-01-22
Changed in openstack-manuals:
assignee: nobody → Mark (rocky-asdf)
Changed in openstack-manuals:
assignee: Mark (rocky-asdf) → nobody
milestone: none → newton
Ryan Selden (ryanx-seldon) wrote :

Anne,

Would you recommend the build download the CDN files if the option is set to local browsing? I would assume by CDN files, you mean any bootstrap, google fonts, and fontawesome etc files, right?

Thanks
Ryan

Changed in openstack-manuals:
assignee: nobody → Ryan Selden (ryanx-seldon)
Anne Gentle (annegentle) wrote :

Hi Ryan,

I do think that downloading the files to serve locally meets the needs of an "offline browsing/building the docs" scenario.

Yeah, I think any files served on maxcdn like this line:

<link href="http://maxcdn.bootstrapcdn.com/font-awesome/4.2.0/css/font-awesome.css" rel="stylesheet">

Are what we're looking to bring local as an option.

Thanks,
Anne

Ryan Selden (ryanx-seldon) wrote :

Anne,

One even simpler option is to remove the use of a CDN anywhere - we discussed this in https://launchpad.net/bugs/1502806 - and my patch https://review.openstack.org/#/c/333573/ addresses it except for the google fonts include. I could update to include that - what are your thoughts?

Thanks
Ryan

Anne Gentle (annegentle) wrote :

Yeah that is probably fine -- though I did ask if we have any way to test the difference?

Ryan Selden (ryanx-seldon) wrote :

Not sure what you mean?

Anne Gentle (annegentle) wrote :

Oh maybe performance won't matter since Non-CDN is only when served locally?

Ryan Selden (ryanx-seldon) wrote :

Added another patch for removing CDN from OpenSans googlefont and IE compatibility scripts.

See https://review.openstack.org/#/c/339747

Changed in openstack-manuals:
milestone: newton → ocata
Changed in openstack-manuals:
status: Confirmed → In Progress

What's the update on these patches?

Brian Moss (bmoss) on 2017-02-24
affects: openstack-manuals → openstack-doc-tools
Changed in openstack-doc-tools:
milestone: ocata → none

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: master
Review: https://review.openstack.org/339747
Reason: Stale review - let's abandon.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers