gnocchi lacks subcommand bash-completion

Bug #1514705 reported by Atsushi SAKAI
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-manuals
Fix Released
Undecided
Atsushi SAKAI

Bug Description

For generating CLI ref.
"gnocchi bash-completion" is also needed for document auto-generation.
Sorry for disturbing. (previously reported help authenication problem)
This is should be last one.

Related Bug (already fixed)
https://bugs.launchpad.net/python-gnocchiclient/+bug/1505788

Revision history for this message
Julien Danjou (jdanjou) wrote :

Why do you add openstack-manuals?

Revision history for this message
Julien Danjou (jdanjou) wrote :

Actually I don't even understand the bug.

Changed in python-gnocchiclient:
status: New → Incomplete
Atsushi SAKAI (sakaia)
summary: - gnocchi lacks subcommand bash-completion i
+ gnocchi lacks subcommand bash-completion
Atsushi SAKAI (sakaia)
Changed in openstack-manuals:
assignee: nobody → Atsushi SAKAI (sakaia)
Revision history for this message
Atsushi SAKAI (sakaia) wrote :

Julien
Sorry for my mis-understanding.

I checked the following code and found that it uses subcommand bash-completion only (not using subcommand complete)
I will post the patch to support it on document tool side.

https://github.com/openstack/openstack-doc-tools/blob/master/bin/doc-tools-update-cli-reference
https://github.com/openstack/openstack-doc-tools/blob/master/os_doc_tools/commands.py

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-doc-tools (master)

Fix proposed to branch: master
Review: https://review.openstack.org/243577

Changed in openstack-manuals:
status: New → In Progress
Revision history for this message
Julien Danjou (jdanjou) wrote :

I understand better, thanks. Indeed, that looks like an issue on the manual side. Thanks for fixing :)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-doc-tools (master)

Reviewed: https://review.openstack.org/243577
Committed: https://git.openstack.org/cgit/openstack/openstack-doc-tools/commit/?id=5143dbae01c3e3911f23c3c081f09fbe9033553e
Submitter: Jenkins
Branch: master

commit 5143dbae01c3e3911f23c3c081f09fbe9033553e
Author: Atsushi SAKAI <email address hidden>
Date: Tue Nov 10 22:04:02 2015 +0900

    Add bash-completion/complete selection for command list parsing

    gnocchi commands supports complete only (not supported bash-completion)
    For supporting, it adds bash-completion/complete detection
    in generate_command.
    Instead, it removes specify "bash-completion" in generate_subcommand.

    i.e call relation is follows
      generate_subcommand <= remove specify "bash-completion"
                             remove set subcommands
        generate_command <= add method detection
                             newly set subcommands
        discover_and_generate_subcommands
           discover_subcommands <= use subcommands
                                    for bash-completion or complete

    Change-Id: Ia076114aa7fda218ed6fc349951df536e11fb710
    Closes-Bug: #1514705

Changed in openstack-manuals:
status: In Progress → Fix Released
Julien Danjou (jdanjou)
no longer affects: python-gnocchiclient
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.