weave merge removes text before first conflict

Bug #35886 reported by David Allouche
4
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Aaron Bentley
bzr (Ubuntu)
Fix Released
Medium
Jeff Bailey

Bug Description

When using "remerge --merge-type=weave" with a specified conflicted file, the part of the file before the first weave-merge conflict is ignored. If weave merge succeeds without conflict, the resulting file is empty.

I have not checked whether the problem occurs without specified files.

Aaron Bentley (abentley)
Changed in bzr:
status: Unconfirmed → Confirmed
Revision history for this message
Aaron Bentley (abentley) wrote :

I can confirm that this applies to merge as well as remerge, so it's not related to having specified files. I have eyeballed the tree transform weave merge code several times, but can see nothing wrong on the transform side.

It can be reproduced by merging bzr.dev (revno 1594) into bzr.ab (revno 1576), which destroys the contents of bzrlib/transport/local.py

Aaron Bentley (abentley)
Changed in bzr:
assignee: nobody → aaron-bentley
status: Confirmed → In Progress
Aaron Bentley (abentley)
Changed in bzr:
status: In Progress → Fix Committed
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

I can confirm the bug as well. It destroyed the file content when doing a merge which results in conflicts with traditional 3-way merging, and a successful merge with weave.

The code currently in the bzr.dev branch was tested and doesn't show the same problem.

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Dapper's package version 0.8~2006032008 has the problem.

Changed in bzr:
status: Unconfirmed → Confirmed
Jeff Bailey (jbailey)
Changed in bzr:
status: Confirmed → Unconfirmed
assignee: nobody → jbailey
Revision history for this message
Jeff Bailey (jbailey) wrote :

Fixed in Dapper bzr_0.8~200603230747-0ubuntu1

Changed in bzr:
status: Unconfirmed → Fix Released
John A Meinel (jameinel)
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.