When asserting whether variables are equal, assertEqual should be used

Bug #2002460 reported by zhangtongjian
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cyborg (OpenStack)
Fix Released
Undecided
Unassigned

Bug Description

When asserting whether two variables are equal, assertEqual should be used instead of assertTrue.

 def test_get_all(self, mock_dp):
    mock_dp.return_value = self.fake_dp_objs
    ...
    self.assertTrue(len(out_dps), len(self.fake_dp_objs))
    ...
    for in_dp, out_dp in zip(self.fake_dp_objs, out_dps):
            self._validate_dp(in_dp, out_dp)

Related Code:
https://github.com/openstack/cyborg/blob/master/cyborg/tests/unit/api/controllers/v2/test_device_profiles.py#100

https://github.com/openstack/cyborg/blob/master/cyborg/tests/unit/api/controllers/v2/test_device_profiles.py#115
...

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cyborg (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cyborg/+/869696

Wenping Song (wenping1)
Changed in openstack-cyborg:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cyborg (master)

Reviewed: https://review.opendev.org/c/openstack/cyborg/+/869696
Committed: https://opendev.org/openstack/cyborg/commit/3f052b6ad4769e410a55aae2927abcac5f650889
Submitter: "Zuul (22348)"
Branch: master

commit 3f052b6ad4769e410a55aae2927abcac5f650889
Author: zhangtongjian <email address hidden>
Date: Wed Jan 11 11:28:20 2023 +0800

    fix function usage errors

    When comparing variables, should use assertEqual

    Related-Bug: #2002460

    Change-Id: Ia2765d49da62733efacc0e095423e7a1bb84197d

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cyborg (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cyborg/+/869701

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cyborg/+/869702

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cyborg/+/869706

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cyborg (master)

Reviewed: https://review.opendev.org/c/openstack/cyborg/+/869701
Committed: https://opendev.org/openstack/cyborg/commit/99858d03b82be6de3598279b8e94c7e770fdfaf3
Submitter: "Zuul (22348)"
Branch: master

commit 99858d03b82be6de3598279b8e94c7e770fdfaf3
Author: zhangtongjian <email address hidden>
Date: Wed Jan 11 18:44:23 2023 +0800

    fix function usage errors

    When comparing variables, should use assertEqual

    Related-Bug: #2002460

    Change-Id: I59c6910666a0f75934162126dd35883dc32449dc

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/cyborg/+/869702
Committed: https://opendev.org/openstack/cyborg/commit/05505927a5aa243870d01c477acc0da9df0adf70
Submitter: "Zuul (22348)"
Branch: master

commit 05505927a5aa243870d01c477acc0da9df0adf70
Author: zhangtongjian <email address hidden>
Date: Wed Jan 11 18:49:12 2023 +0800

    When asserting the number of members obtained in unit test deployables, should use assertEqual

    Related-Bug: #2002460

    Change-Id: I2a5bf79b2eb0355edbc07e54cbb51c87f860e97d

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cyborg (master)

Reviewed: https://review.opendev.org/c/openstack/cyborg/+/869706
Committed: https://opendev.org/openstack/cyborg/commit/eafcc2fc64df6d8c8c2e3b709e9d4e7d5e7be9b7
Submitter: "Zuul (22348)"
Branch: master

commit eafcc2fc64df6d8c8c2e3b709e9d4e7d5e7be9b7
Author: zhangtongjian <email address hidden>
Date: Thu Jan 12 09:02:11 2023 +0800

    Fix the wrong use of variable assertions in unit tests

    When comparing variables, should use assertEqual

    Closed-Bug: #2002460

    Change-Id: Iec2e9eec8fea6e5453704c22235fb860211af1a3

Wenping Song (wenping1)
Changed in openstack-cyborg:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.