Preseed has corrupt late_command when using both expert_disk and autostart_puppet

[Mark T. Voelker]

From Ian:
Looks to me like expert_disk is key here (since we all like
autostart_puppet):

d-i preseed/late_command string in-target puppet agent --test
--waitforcert 0 || true;\
if [ "`debconf-get netcfg/no_default_route`" = "true" ] ; then in-target
sed -i.bak -e '/^\tgateway /d' /etc/network/interfaces; fi ;\
<% if expert_disk -%>/sbin/lvremove -f nova-volumes/hack;\<% end -%>
<% if autostart_puppet %>sed -e 's/START=no/START=yes/' -i
/target/etc/default/puppet ;\<% end -%>
<% if late_command -%><%= late_command -%>
<% end -%>
wget -O /dev/null
http://$http_server:$http_port/cblr/svc/op/nopxe/system/$system_name ; \
wget -O /dev/null
http://$http_server:$http_port/cblr/svc/op/trig/mode/post/system/$system_na
me ; \
true

late_command, as currently defined in the manifest, starts with a
linefeed. One of the two options means its linefeed is used
appropriately. Both and you find the two commands run into each other as:

/sbin/lvremove -f nova-volumes/hack;\sed -e 's/START=no/START=yes/' -i
/target/etc/default/puppet ;\

[Mark T. Voelker (mvoelker)]

No longer reproducible; I believe this got fixed in one of the late_command cleanups a while back.