Cobbler node define shouldn't be in site.pp

[Michael Chapman]

Move cobbler node definition out of site.pp and into cobbler_node.pp and add extra parameters for clients to override.

[Michael Chapman (michaeltchapman)]

https://github.com/CiscoSystems/folsom-manifests/pull/51

[Ian Wells (ijw-ubuntu)]

Yes, but this still doesn't work if I have a completely different node (i.e. it's not a UCS), or two sorts of hardware mixed together, or nodes with different admin passwords...

For a good chunk of people installing, cobbler_node is completely fine and putting it in front of them is presenting them with complexity they don't need to see. For another chunk of people, cobbler_node is something that needs customising, which is why I put it in site.pp in the first place.

It's basically a judgement call. Someone make a judgement.

[Chris Ricker (chris-ricker)]

everyone will have to define their power management so I'd say it should stay in site.pp

[Michael Chapman (michaeltchapman)]

You can still define your power management:

cobbler_node { "control-server": node_type => "control", mac => "00:11:22:33:44:55", ip => "192.168.242.10", power_address => "192.168.242.110", power_user => "administrator", power_password => "super_secure_password" }

I should add another argument for the management type, though.

[Chris Ricker (chris-ricker)]

right, it's the type stuff I was referring to -- particularly since I'd expect most of our customers change that to ucsm

[Michael Chapman (michaeltchapman)]

New PR is here: https://github.com/CiscoSystems/folsom-manifests/pull/52

I've added the power_type argument and split it off from the other changes.

My motivation is twofold:
1- that site.pp should only contain site config and node definitions. The cobbler_node define is similar to every other define we use, and they are all put in either core.pp or cobbler_node.pp. I don't think it's any different.
2- If a customer is deploying to heterogeneous hardware they have to make multiple defines under the current scheme. This can be avoided by adding all the needed parameters to the define.

An alternative is to keep the parameters, but set them to default to a global variable in site.pp. This would make the node definition smaller but add three more global variables, while maintaining the ability to have different power options for each node.

[Chris Ricker (chris-ricker)]

https://github.com/CiscoSystems/grizzly-manifests/pull/13 for grizzly

[Chip (cbaesema)]

Merged to grizzly branch