Need proper support for n1kv plugin configuration through puppet COI

[Neehar Athalye]

When we attempted an install of N1KV plugin through COI, the plugin did not get registered with the quantum-server and in some cases caused the server to break and not start at all. Ultimately the root cause was found out to be the missing n1kv configuration information from either site.pp/core.pp.
We ended up adding the following piece of code to site.pp to get around this problem.

node 'ostack-controller' inherits os_base {
  class { 'control':
    tunnel_ip => '1.1.12.2'
  }

  quantum_plugin_cisco {
        'N1KV:1.1.12.250/username' : value => 'admin';
        'N1KV:1.1.12.250/password' : value => 'Sfish123';
 }

 quantum_plugin_cisco {
                        'CISCO_N1K/integration_bridge' : value => 'br-int';
                        'CISCO_N1K/tunnel_bridge' : value => 'br-int';
                        'CISCO_N1K/local_ip' : value => '1.1.12.2';
                        'CISCO_N1K/tenant_network_type' : value => 'local';
                        'CISCO_N1K/bridge_mappings' : value => ' ';
                        'CISCO_N1K/default_policy_profile' : value => 'dhcp_pp';
                        'CISCO_N1K/POLL_DURATION' : value => '10';
                        'DATABASE/sql_connection' : value => 'mysql://quantum:n1k12345@127.0.0.1/quantum?charset=utf8';
 }

}

Michael Chapman suggested that quantum_cisco_plugin native type should be used in puppet manifests.
For more specific details, please contact Michael Chapman or Neehar.

[Pradeep Kilambi (pkilambi)]

We already have native types in our multi-node branch for quantum::plugin::cisco. Could be this was before the n1k multi-node branch merged the newest multi-node changes?

Marking as incomplete. I dont think there is anything to do here.