gerrit should include merge commit sha1 in change-merged events

Bug #929723 reported by James E. Blair
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
In Progress
James E. Blair

Bug Description

The change-merged event only includes information about the proposed change that was merged, but if a merge commit was generated for that commit, then it is not included. Typically actions that we would want to take in jenkins would be on the tree with the merge-commit as tip rather than the original commit (which may be based on something other than the current tip). So gerrit should be modified to include that SHA1, and the gerrit trigger plugin should be modified to (optionally?) use it if present.

See: gerrit-server/src/main/java/com/google/gerrit/server/git/

Tags: gerrit
James E. Blair (corvus)
tags: added: gerrit
Changed in openstack-ci:
importance: Undecided → High
status: New → Triaged
James E. Blair (corvus)
Changed in openstack-ci:
assignee: nobody → James E. Blair (corvus)
Revision history for this message
James E. Blair (corvus) wrote :

Note that if multiple changes with dependencies get merged at once (because their ancestor is merged) there will be one merge commit used for all the changes. Example:

* e501593 Merge changes Ic9f0d336,Ia4a7402a,I8a62490c
| * c83efb1 test c
| * d3ab4ca test b
| * 57c10a0 test a
* | 3c194f3 test merge
* 9c2d83c common head

(test a, test b, and test c (all based on "common head" were merged into "test merge" via the gerrit generated merge commit on top))

In that case we may be using the same merge commit sha1 for multiple events. It's probably the correct thing to do, however, we'll want to know that when writing jenkins jobs. We may end up making the same tarball twice (however, it should be the _same_ tarball, for whatever that's worth).

Changed in openstack-ci:
status: Triaged → In Progress
Revision history for this message
Monty Taylor (mordred) wrote :

As part of this, having the ability to have jenkins write the merge SHA back into the gerrit review comment "change merged" ... and also having gerrit add a note about the Change-ID into the commit message for the merge commit.

Changed in openstack-ci:
milestone: none → folsom
importance: High → Medium
Monty Taylor (mordred)
Changed in openstack-ci:
milestone: folsom → grizzly
Monty Taylor (mordred)
Changed in openstack-ci:
importance: Medium → Wishlist
James E. Blair (corvus)
Changed in openstack-ci:
milestone: grizzly → none
Revision history for this message
George Young (georgey21) wrote :

Added request for Gerrit event extension here:

Revision history for this message
George Young (georgey21) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.