OpenStack Core Infrastructure

Making comments

Bug #845211 reported by Kevin L. Mitchell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
Fix Released
Wishlist
Khai Do
OpenStack Core Infrastructure icehouse

Bug Description

In Gerrit, it is not obvious how to make a regular comment on a patch set. One has to click "Review" and select "No Score." This non-obviousness makes it difficult for patch submitters to figure out how to reply to comments by reviewers.

Tags: gerrit
James E. Blair (corvus)
Changed in openstack-ci:
importance: Undecided → Wishlist
status: New → Triaged
assignee: nobody → James E. Blair (corvus)
Monty Taylor (mordred)
tags: added: gerrit
Revision history for this message
James E. Blair (corvus) wrote :

This should be reported to http://code.google.com/p/gerrit/issues/list

Changed in openstack-ci:
assignee: James E. Blair (corvus) → nobody
Revision history for this message
Khai Do (zaro0508) wrote :

There are major UI changes changes to upstream gerrit as of ver 2.8. The review button has been replaced with a 'reply' button right at the very top of the page. This seems like a pretty obvious way to comment on patches to me.

Khai Do (zaro0508)
Changed in openstack-ci:
assignee: nobody → Khai Do (zaro0508)
Revision history for this message
Khai Do (zaro0508) wrote :

We have upgraded to gerrit 2.8. The UI changes I have mentioned can be used if you switch to the new change screen. Not sure that it's any better though :)

Changed in openstack-ci:
assignee: Khai Do (zaro0508) → nobody
Revision history for this message
Tom Fifield (fifieldt) wrote :

There is now an "Add Comment" button at the bottom of each review. Is that sufficient to close this bug?

Changed in openstack-ci:
status: Triaged → Incomplete
Revision history for this message
Jeremy Stanley (fungi) wrote :

I agree the "Add Comment" button at the bottom of each review comment area in the old change screen also makes this relatively obvious.

Changed in openstack-ci:
status: Incomplete → Fix Released
assignee: nobody → Khai Do (zaro0508)
milestone: none → icehouse
Revision history for this message
Kevin L. Mitchell (klmitch) wrote :

I agree that "Add Comment" satisfactorily corrects the bug.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.