os-loganalyze incorrectly rendering logs

Bug #1367021 reported by Joe Gordon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
Fix Committed
Undecided
Sean Dague

Bug Description

2014-09-04 21:13:49.821 DEBUG nova.api.openstack.wsgi [req-9aa00755-a0b8-41a4-bcda-7408acb2472e ServerAddressesNegativeTestJSON-1391620620 ServerAddressesNegativeTestJSON-1830205437] Calling method '>' (Content-type='application/json', Accept='application/json') _process_stack /opt/stack/new/nova/nova/api/openstack/wsgi.py:936

In http://logs.openstack.org/81/119081/2/check/check-tempest-dsvm-full/17bcc85/logs/screen-n-api.txt.gz#_2014-09-04_21_13_49_821

is not correct, when downloading the file we see it actually reads:

2014-09-04 21:13:49.821 DEBUG nova.api.openstack.wsgi [req-9aa00755-a0b8-41a4-bcda-7408acb2472e ServerAddressesNegativeTestJSON-1391620620 ServerAddressesNegativeTestJSON-1830205437] Calling method '<bound method Controller.show of <nova.api.openstack.compute.servers.Controller object at 0x7f92f455d990>>' (Content-type='application/json', Accept='application/json') _process_stack /opt/stack/new/nova/nova/api/openstack/wsgi.py:936

"Calling method '<bound method Controller.show of <nova.api.openstack.compute.servers.Controller object at 0x7f92f455d990>>'" not "Calling method '>'"

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-loganalyze (master)

Fix proposed to branch: master
Review: https://review.openstack.org/120064

Changed in openstack-ci:
assignee: nobody → Sean Dague (sdague)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-loganalyze (master)

Reviewed: https://review.openstack.org/120064
Committed: https://git.openstack.org/cgit/openstack-infra/os-loganalyze/commit/?id=e3aa0bcb83fbf545caa287d4647e9b8ddaedbc21
Submitter: Jenkins
Branch: master

commit e3aa0bcb83fbf545caa287d4647e9b8ddaedbc21
Author: Sean Dague <email address hidden>
Date: Tue Sep 9 07:24:13 2014 -0400

    Fix lost content escaping for html safety

    During generator refactoring to enable the swift backend, we
    incorrectly set a state flag which meant we *never* escaped < > any
    more. Apparently it took a while for people to notice.

    The fix is to actually correctly set the flag in the _discover_html
    function. A unit test is added to ensure that we don't break this
    again in the future.

    Change-Id: Ifa9d34c45047a257a392c729aaf792f17d8ff453
    Closes-Bug: #1367021

Changed in openstack-ci:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.