puppet coding style in puppet-yum

Bug #1334751 reported by Longgeek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
Fix Committed
Undecided
Longgeek

Bug Description

1. No .gitreview file

2. No Rakefile file

# rake lint
2014-06-26 16:33:21.141 | rake aborted!
2014-06-26 16:33:21.141 | No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, Rakefile.rb)
2. cat puppet-yum/manifests/repo.pp

define yum::repo (
  $description = '',
  $url_path = false,
  $enabled = 0,
  $gpgcheck = 0,
  $baseurl = absent,
  $mirrorlist = absent,
  $cron_hour = 2,
  $cron_minute = 0,
) {

Look bad.

Longgeek (longgeek)
Changed in openstack-ci:
assignee: nobody → Longgeek (longgeek)
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-yum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/102876

Changed in openstack-ci:
status: New → In Progress
Longgeek (longgeek)
description: updated
Longgeek (longgeek)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-yum (master)

Reviewed: https://review.openstack.org/102876
Committed: https://git.openstack.org/cgit/openstack-infra/puppet-yum/commit/?id=99bc571b2e8424e5b234afe729e5e3c7ce61f4c6
Submitter: Jenkins
Branch: master

commit 99bc571b2e8424e5b234afe729e5e3c7ce61f4c6
Author: Longgeek <email address hidden>
Date: Fri Jun 27 00:16:31 2014 +0800

    Add .gitreview Rakefile files and update puppet coding style

    All of the fat comma arrows (=) in a resource’s attribute/value list
    should be aligned.
    Put a trailing comma after the final resource parameter.

    Change-Id: If9567bf3c1978571970cac390df80f839627f45d
    Closes-Bug: #1334751

Changed in openstack-ci:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.