Gerrit Code-Review -1 description is inaccurate

[Antoine "hashar" Musso]

In Gerrit, each change has a code-review label which can be voted as:

+2 Looks good to me (core reviewer)
+1 Looks good to me, but someone else must approve
 0 No score
-1 I would prefer that you didn't merge this
-2 Do not merge

The -1 score seems to be always used on a change that has been proposed but is not merged. Hence the use of past 'I would prefer that you didn't merge this' does not make any sense since the patch is usually not merged.

On Wikimedia Gerrit installation we are using:

 -1 There's a problem with this change, please improve

Seems to better match the voter thought.

[Khai Do (zaro0508)]

The configuration for the code-review label is in All-Projects/project.config therefore this will require an infra core to manually changed the -1 description.

[Jeremy Stanley (fungi)]

I'm fine changing this whenever. Do we need some bikeshedding over the actual text, or do we just want to copy WMF's?

[Antoine "hashar" Musso (hashar)]

Wikimedia community already did the bike shed step, so you can save some time and blindly reuse our message:

 Code-Review -1 : There's a problem with this change, please improve

[Antoine "hashar" Musso (hashar)]

Clark Boylan proposed https://review.openstack.org/#/c/116176/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/116176
Committed: https://git.openstack.org/cgit/openstack-infra/config/commit/?id=1c66994e00e81a7d0bd002b1eb6100a3d86e3ed5
Submitter: Jenkins
Branch: master

commit 1c66994e00e81a7d0bd002b1eb6100a3d86e3ed5
Author: Clark Boylan <email address hidden>
Date: Thu Aug 21 22:18:01 2014 -0700

    Propose new Code Review -1 text

    New Code Review -1 default text has been proposed on a ML thread.
    Propose it here so that we can "review" it. If we can agree this should
    be updated as in this change a Gerrit admin will have to update
    All-Projects directly then this change can be merged.

    Fixes-bug: 1258899
    Change-Id: I145d393bba6d7ebede7fbcd1f592937a9daadaf9