Gerrit does not emit events on draft publication

[Pablo Andres Fuente]

If a review is submitted using the -D option, after you click on the Publish button, Jenkins don't start automatically the check process.

As an example: https://review.openstack.org/#/c/58021/

[Jeremy Stanley (fungi)]

Gerrit 2.4, running on review.openstack.org, does not emit events for draft publication, so there is nothing for Zuul to act on. Later Gerrit releases (which we eventually hope to run) have added an event to the stream for this, thus the "fix committed" status... we won't be backporting this fix but we do eventually hope to upgrade once we can reach upstream feature parity with our current fork. There are two workarounds:

1. (preferred) Do not use drafts. On a public code review system for free software, there is little benefit to Gerrit's "draft" feature. Drafts are not actually private, so if something is not ready for review mark it "work in progress" instead.

2. (you used the draft feature anyway) Either push a new patchset such as a trivial rebase, or leave a review comment which says only "recheck no bug" and nothing else. Either of these actions should cause Zuul to see an event which will trigger check tests.

[Khai Do (zaro0508)]

This issue is fixed in gerrit version 2.8 -> https://gerrit-documentation.storage.googleapis.com/Documentation/2.8.2/cmd-stream-events.html

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/92158

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/92268

[Khai Do (zaro0508)]

Will not fix this issue. Openstack has decided to disable drafts in gerrit.. http://lists.openstack.org/pipermail/openstack-dev/2014-May/035563.html

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/92268
Committed: https://git.openstack.org/cgit/openstack-infra/zuul/commit/?id=dcc53b156025525c1d371400d037db4a62b5cde4
Submitter: Jenkins
Branch: master

commit dcc53b156025525c1d371400d037db4a62b5cde4
Author: Khai Do <email address hidden>
Date: Mon May 5 18:08:22 2014 -0700

    add support for draft-published event

    Gerrit 2.4 did not provide a stream event for draft patchsets therefore it was not
    supported in zuul either. We've just upgraded to Gerrit 2.8 which does provide a
    new draft-published stream event. This change will make zuul aware of the draft-published
    event.

    Change-Id: Ica363b4672cfce375d64463636d84e92c2949fd6
    Partial-Bug: #1255166

[Khai Do (zaro0508)]

zuul now supports detection of draft changes with change https://review.openstack.org/#/c/92268