manage-projects needs to write its logging somewhere

Bug #1245905 reported by Anita Kuno
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
Fix Released
Medium
Anita Kuno

Bug Description

http://git.openstack.org/cgit/openstack-infra/jeepyb/tree/jeepyb/cmd/manage_projects.py logs but since it doesn't write out the logging to a file, that information gets lost during a failure to create a repo.

Adding logging for manage-projects would help discover failures or errors in the future if/when manage-projects fails to create a repo.

<fungi> Oct 28 20:50:28 review puppet-agent[18398]: (/Stage[main]/Openstack_project::Gerrit/Exec[manage_projects]) Failed to call refresh: /usr/local/bin/manage-projects returned 1 instead of one of [0] at /opt/config/fungi/modules/openstack_project/manifests/gerrit.pp:325
<fungi> that's, um, not helpful
<fungi> i think we need to have that script log somewhere
<fungi> or maybe we already do
<fungi> yeah, looks like it's got logging, we're just not configuring to write it anywhere (instead it's going to stdout and getting swallowed by the puppet agent)

<fungi> anteaya: right, we'd probably make a logging.conf for manage-projects, have puppet install that somewhere on review.o.o and then slightly change the exec for manage-projects to use that logging.conf (may require a tad more code in jeepyb to have a command-line option to be able to pass in the extra filename for that on the cli)

Anita Kuno (anteaya)
Changed in openstack-ci:
assignee: nobody → Anita Kuno (anteaya)
James E. Blair (corvus)
Changed in openstack-ci:
status: New → Triaged
importance: Undecided → Medium
tags: added: low-hanging-fruit
Anita Kuno (anteaya)
Changed in openstack-ci:
assignee: Anita Kuno (anteaya) → nobody
Anita Kuno (anteaya)
Changed in openstack-ci:
assignee: nobody → Anita Kuno (anteaya)
Revision history for this message
Jeremy Stanley (fungi) wrote :

The easiest solution here is to add the logoutput option on the puppet exec for manage-projects, similar to what we did in https://review.openstack.org/60959 .

Anita Kuno (anteaya)
Changed in openstack-ci:
assignee: Anita Kuno (anteaya) → nobody
Revision history for this message
Anita Kuno (anteaya) wrote :

I had this bug report open in two different tabs. Hence the assignment hopscotch.

I'll take it again and thanks for the example fungi.

Changed in openstack-ci:
assignee: nobody → Anita Kuno (anteaya)
Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

for the record, as per this commit manage-projects is run by hand, temporarily.
https://github.com/openstack-infra/config/commit/3f9175647745c9e84b4516439ef7d0c67c3335a1

We may re-visit this bug to logoutput when it's executed from puppet.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/72158

Changed in openstack-ci:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.openstack.org/72158
Committed: https://git.openstack.org/cgit/openstack-infra/config/commit/?id=76ca969b165922036f5cd505a70fb8bf231eb9ec
Submitter: Jenkins
Branch: master

commit 76ca969b165922036f5cd505a70fb8bf231eb9ec
Author: Anita Kuno <email address hidden>
Date: Sun Feb 9 13:23:50 2014 -0500

    Add logging to manage-projects

    This patch adds logging to the puppet exec for manage-projects
    within gerrit.pp.

    It also adds logging to jeepyb, which can also cover logging for
    manage-projects, which is a script within jeepyb.

    Change-Id: I4cd1137e4bf62e0d19a8a337c98b3a33df38a0c0
    Fixes-bug: 1245905

Changed in openstack-ci:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.