Upgrade puppetlabs apache module to 0.7.0

[Márton Kiss]

The CI infrastructure currently using v0.0.4 of the official PuppetLabs apache module. We need to upgrade it to at least v0.7.0, because current module doesn't support overriding of AllowOverride option, and the group-staging.openstack.org want to use built-in url-rewrite , where we need to change default value of AllowOverride.

MODULES["puppetlabs-apache"]="0.0.4"

Before upgrade, need to check config modules using apache module to avoid crashing existing functionality.
Modules using apache:
grep "include apache" * -R
modules/cgit/manifests/init.pp: include apache
modules/lodgeit/manifests/site.pp: include apache
modules/lodgeit/manifests/init.pp: include apache
modules/zuul/manifests/init.pp: include apache
modules/pypimirror/manifests/init.pp: include apache
modules/planet/manifests/site.pp: include apache
modules/openstack_project/manifests/cacti.pp: include apache
modules/openstack_project/manifests/static.pp: include apache
modules/openstack_project/manifests/static.pp: include apache::mod::wsgi
modules/graphite/manifests/init.pp: include apache
modules/mailman/manifests/init.pp: include apache
modules/jenkins/manifests/master.pp: include apache
modules/gerrit/manifests/init.pp: include apache
modules/mediawiki/manifests/init.pp: include apache
modules/logstash/manifests/web.pp: include apache
modules/meetbot/manifests/init.pp: include apache

Excerpt from apache module Changelog:
2013-07-09 Release 0.7.0
Changes:
- Essentially rewrite the module -- too many to list
- `apache::vhost` has many abilities -- see README.md for details
- `apache::mod::*` classes provide httpd mod-loading capabilities
- `apache` base class is much more configurable
...

[Jeremy Stanley (fungi)]

We discussed the upgrade possibilities a few weeks ago with Dan Bode. It sounds like the easiest path forward is to temporarily fork one of the two modue versions so we can rename it and run both side by side for a piecemeal migration, one system at a time.

As for AllowOverride, is it not possible to set that in a custom vhost template rather than relying on the default used by the apache module? We take that approach with a number of other sites and Web applications where we've needed to deviate substantially from that module's default configuration assumptions.

[Márton Kiss (marton-kiss)]

An option could be to move the drupal root's .htaccess file under vhost. This solution also requires a custom vhost file, but it could be generated from a manifest template also as a workaround, and we can keep the 0.0.4 version. As I experienced an updated Puppetlabs apache module really means a major rewrite of apache releated parts of a module.

[Márton Kiss (marton-kiss)]

A custom template is supported in v0.0.4:

  apache::vhost { $site_name:
    port => 80,
    priority => '50',
    docroot => $site_docroot,
    require => File[$site_docroot],
    template => 'drupal/drupal.vhost.erb',
  }

The vhost template also includes the Drupal .htaccess, so this is a perfect solution.