update_bug should use review owner instead of latest commiter

[Monty Taylor]

On 06/08/2012 06:23 PM, Brian Waldon wrote:
> I'm of the opinion that whatever is calling update_bug.py (I forget what repo its in) should be giving it the review owner rather than the last review committer as its argument. Agree?

Also:

James Blair wrote:
zuul/lib/gerrit.py wants to be an independent gerrit API library in
Python but I haven't split it out yet. Depending on when this gets
implemented for update_bug, you may want to use it or temporarily copy
it along with update_bug. It should handle some of the boilerplate
around querying gerrit for information about the change.

[Bhuvan Arumugam (bhuvan)]

The script is in openstack-ci-puppet.

barumuga@lexpad:~/projects/openstack-ci-puppet$ find . -name update_bug.py
./modules/gerrit/files/scripts/update_bug.py

This is called from a gerrit hook. The hook doesn't seem to be stored in git, yet. We should fix the hook to pass review-owner to this script.

[Thierry Carrez (ttx)]

The current hook doesn't get enough information to use the review owner.

Long-term plan is to rewrite updatebug into a gerrit streamevents daemon, which would apparently provide us enough information.

[Khai Do (zaro0508)]

Currently the update_bug script is in jeepyb project. It gets called from the following config scripts:
 - http://git.openstack.org/cgit/openstack-infra/config/tree/modules/openstack_project/files/gerrit/change-merged
 - http://git.openstack.org/cgit/openstack-infra/config/tree/modules/openstack_project/templates/gerrit_patchset-created.erb

Thierry is correct, Gerrit does not provide info about the change owner in the hooks for us to pass to the update_bug script -> https://gerrit-review.googlesource.com/Documentation/config-hooks.html

An upstream bug has been created to add change owner info to the Gerri -> hooks: https://code.google.com/p/gerrit/issues/detail?id=2596

[Khai Do (zaro0508)]

upstream change to add change owner to gerrit hooks: https://gerrit-review.googlesource.com/#/c/56252

[Khai Do (zaro0508)]

change 56252 has been merged and gerrit with that change has been updated on review-dev.o.o