[identity] make vault_keystone name variable

Bug #1714523 reported by Stefan Hoffmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack + Chef
Fix Released
Undecided
Stefan Hoffmann

Bug Description

At the openstack-identity-cookbook in _fernet_tokens the vault name is hard coded with 'keystone'
It would be nice to use a variable to define the vault name.
Like for all other secret data bags it would be useful and consistent to use a secrets data bag whose name is specified in an attribute (I would suggest ['openstack']['secret']['secrets_data_bag']).

https://github.com/openstack/cookbook-openstack-identity/blob/275c12c3a614df47feac20bb853b55d393b24556/recipes/_fernet_tokens.rb#L36

Revision history for this message
Samuel Cassiba (scassiba) wrote :

Hello Stefan!

It is great that you're providing this feedback. We can help get you set up to deliver the desired changes. We have an IRC channel on Freenode in which the core team resides at #openstack-chef where we can converse in real-time.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-identity (master)

Fix proposed to branch: master
Review: https://review.openstack.org/501274

Changed in openstack-chef:
assignee: nobody → Stefan Hoffmann (mr-hopeman)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-identity (master)

Reviewed: https://review.openstack.org/501274
Committed: https://git.openstack.org/cgit/openstack/cookbook-openstack-identity/commit/?id=79e57bd7999b6df72c2094275e763e71b266f204
Submitter: Jenkins
Branch: master

commit 79e57bd7999b6df72c2094275e763e71b266f204
Author: Stefan Hoffmann <email address hidden>
Date: Wed Sep 6 10:59:38 2017 +0200

    use variable fernet-key data bag

    instead of hard coded vault name the attribute
    ['openstack']['secret']['secrets_data_bag'] is used.

    Change-Id: I286fbfe89395544d1f8d0139acca0d689e4737fa
    Closes-Bug: #1714523

Changed in openstack-chef:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.