[identity] use more options at keystone bootstrap

Bug #1714510 reported by Stefan Hoffmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack + Chef
Fix Released
High
Samuel Cassiba

Bug Description

In openstack-identity-cookbook server-apache.rb some options at the "keystone bootstrap" command are removed.
I can't see any reason for this. At my environment this command only work with the bootstrap-username, bootstrap-project-name, bootstrap-role-name and bootstrap-service-name options.

Before removing options the command was in recipe registration.rb
'execute 'bootstrap_keystone' do
  command "keystone-manage bootstrap \\
          --bootstrap-password #{admin_pass} \\
          --bootstrap-username #{admin_user} \\
          --bootstrap-project-name #{admin_project} \\
          --bootstrap-role-name #{admin_role} \\
          --bootstrap-service-name keystone \\
          --bootstrap-region-id #{region} \\
          --bootstrap-admin-url #{identity_admin_endpoint} \\
          --bootstrap-public-url #{identity_public_endpoint} \\
          --bootstrap-internal-url #{identity_internal_endpoint}"
end'

now it is at server-apache.rb
'execute 'keystone bootstrap' do
  user 'root'
  command "keystone-manage bootstrap --bootstrap-password \"#{admin_pass}\" --bootstrap-region-id \"#{region}\" --bootstrap-admin-url #{identity_admin_endpoint} --bootstrap-public-url #{identity_public_endpoint} --bootstrap-internal-url #{identity_internal_endpoint}"
end'

At the attributes there is default['openstack']['identity']['admin_user'] to define the user with is created at bootstrap. It takes variableness if the options are removed.

description: updated
Revision history for this message
Samuel Cassiba (scassiba) wrote :

Thanks for reporting this! I've gone back through my notes and can find no good reason for removing the additional flags.

This execute block did need to go in server-apache, but didn't need such simplification. I'm currently running tests with the original invocation in the correct place.

Changed in openstack-chef:
status: New → Confirmed
importance: Undecided → High
Changed in openstack-chef:
assignee: nobody → Samuel Cassiba (scassiba)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-identity (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/500071

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-identity (stable/ocata)

Reviewed: https://review.openstack.org/500071
Committed: https://git.openstack.org/cgit/openstack/cookbook-openstack-identity/commit/?id=b506a894c80cfb0b63c64c3907423371832466b9
Submitter: Jenkins
Branch: stable/ocata

commit b506a894c80cfb0b63c64c3907423371832466b9
Author: Samuel Cassiba <email address hidden>
Date: Fri Sep 1 10:12:29 2017 -0400

    Corrected keystone bootstrapping command

    - the original invocation of keystone-manage bootstrap was in the wrong recipe,
      so it needed to be moved to server-apache for resource ordering. restored the
      original flags used
    - regen .rubocop_todo.yml to satisfy rubocop
    - bumped revision in metadata

    Closes-Bug: #1714510
    Change-Id: I9d3916e7f306d4c0463ec93cad40d2e78bd7eed8

tags: added: in-stable-ocata
Changed in openstack-chef:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-identity (master)

Reviewed: https://review.openstack.org/500068
Committed: https://git.openstack.org/cgit/openstack/cookbook-openstack-identity/commit/?id=995fe07550f34423d2b5f406f53ec8df182ef5a8
Submitter: Jenkins
Branch: master

commit 995fe07550f34423d2b5f406f53ec8df182ef5a8
Author: Samuel Cassiba <email address hidden>
Date: Fri Sep 1 10:12:29 2017 -0400

    Corrected keystone bootstrapping command

    - the original invocation of keystone-manage bootstrap was in the wrong recipe,
      so it needed to be moved to server-apache for resource ordering. restored the
      original flags used
    - regen .rubocop_todo.yml to pass rubocop

    Closes-Bug: #1714510
    Change-Id: I9d3916e7f306d4c0463ec93cad40d2e78bd7eed8

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.