ext4 filesystem is never created in object-storage disk provider

[Chris Crebolder]

Hi,

I was about to report that in stable/juno the disk provider never actually creates the filesystems. The code in providers/disk.rb lines 244-255 checks "unless" against .exitstatus, but the Integers returned by .exitstatus will always return true (line 246 for xfs and 251 for ext4).

* https://github.com/openstack/cookbook-openstack-object-storage/blob/stable/juno/providers/disk.rb#L246
* https://github.com/openstack/cookbook-openstack-object-storage/blob/stable/juno/providers/disk.rb#L251

I notice, however, that this has been fixed in stable/kilo, but for xfs only:
* https://github.com/openstack/cookbook-openstack-object-storage/blob/stable/kilo/providers/disk.rb#L237

Kilo's ext4 line still checks whether .exitstatus is true:
* https://github.com/openstack/cookbook-openstack-object-storage/blob/stable/kilo/providers/disk.rb#L244

This should be changed to match the xfs line that checks for ".error?"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/292920

[OpenStack Infra (hudson-openstack)]

Change abandoned by Samuel Cassiba (<email address hidden>) on branch: master
Review: https://review.openstack.org/292920
Reason: this will have to be handled in the refactor

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/295060
Committed: https://git.openstack.org/cgit/openstack/cookbook-openstack-object-storage/commit/?id=273f67a07e5b5321a08c77f987a88f3d122c8456
Submitter: Jenkins
Branch: stable/liberty

commit 273f67a07e5b5321a08c77f987a88f3d122c8456
Author: Samuel Cassiba <email address hidden>
Date: Sun Mar 20 19:06:57 2016 -0700

    Normalize error status checking for ext4

    ext4 only ever reports true, and does not actually check the error
    codes.

    Change-Id: I51caf49f6628398974e1d22cd6cd2fe69cd68d80
    Closes-Bug: #1497317

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/295061
Committed: https://git.openstack.org/cgit/openstack/cookbook-openstack-object-storage/commit/?id=53acb991ad2ba6e4414eb5c6e477b1e22dfc0d83
Submitter: Jenkins
Branch: stable/kilo

commit 53acb991ad2ba6e4414eb5c6e477b1e22dfc0d83
Author: Samuel Cassiba <email address hidden>
Date: Sun Mar 20 19:07:55 2016 -0700

    Normalize error status checking for ext4

    ext4 only ever reports true, and does not actually check the error
    codes.

    Change-Id: I1da9e39c253c5ddbd3d33934f91b7c2889bb1a36
    Partial-Bug: #1497317

[foot (dmitry-zadvornykh)]

Are you sure about "unless" here
https://github.com/openstack/cookbook-openstack-object-storage/blob/stable/liberty/providers/disk.rb#L245

[Dr. Jens Harbott (j-harbott)]

The object-storage cookbook has been retired.