[block-storage] lock_path of /var/lock/cinder fails on systemd platforms

[Mark Vanderwiel]

On systemd plaftorms like rhel 7.1, /var/lock/cinder gets removed upon reboot and will cause cinder volume to fail.

Change cinder to be more inline with what nova and neutron recommend, just base the lock path from the state path.

Example from nova: https://github.com/stackforge/cookbook-openstack-compute/blob/master/attributes/default.rb

# The lock_path normally uses /var/lock/nova, but it's not allowed in openSUSE,
# so setting lock_path to $state_path/lock like in Neutron.
default['openstack']['compute']['lock_path'] =
  "#{node['openstack']['compute']['state_path']}/lock"

Also, the permissions on this need to be 755 not 700.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/178351

[Ma Wen Cheng (mars914)]

This problem does not exist in other components? like glance, heat, ceilometer etc.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178351
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-block-storage/commit/?id=6f44d7163110c4910e112db576a7e49ca22a6018
Submitter: Jenkins
Branch: master

commit 6f44d7163110c4910e112db576a7e49ca22a6018
Author: Mark Vanderwiel <email address hidden>
Date: Tue Apr 28 14:18:52 2015 -0500

    Fix lock_path to be based upon state path

    On some recent platforms, systemd based, the /var/lock/ path gets
    cleaned up at reboot and causes issues for projects like cinder.
    Nova and neutron changed long ago to base the lock path off the
    state path, this change does the same thing now for cinder.

    Change-Id: Ibe693c21cfc63dd5b6e1753c85081a952005b293
    Closes-Bug: #1449711