[commmon] render_config_file with_section_content only checks first section

Bug #1444696 reported by Mark Vanderwiel on 2015-04-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack + Chef
Low
Mark Vanderwiel

Bug Description

The current logic does not handle the valid, but ugly, case of sections being defined twice like this:

[securitygroup]

# Controls if neutron security group is enabled or not.
# It should be false when you use nova security group.
enable_security_group = <%= node['openstack']['network']['ml2']['enable_security_group'] %>

...

[securitygroup]

# Firewall driver for realizing neutron security group function.
# Default: firewall_driver = neutron.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver
firewall_driver = <%= node["openstack"]["network"]["openvswitch"]["fw_driver"] %>

Changed in openstack-chef:
importance: Undecided → Low

Fix proposed to branch: master
Review: https://review.openstack.org/174110

Changed in openstack-chef:
status: New → In Progress

Reviewed: https://review.openstack.org/174110
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-common/commit/?id=5e37dea3899cc6dd34d52a463c87bf36c57ea871
Submitter: Jenkins
Branch: master

commit 5e37dea3899cc6dd34d52a463c87bf36c57ea871
Author: Mark Vanderwiel <email address hidden>
Date: Wed Apr 15 16:22:52 2015 -0500

    Fix render_config_file with_section_content to handle dup sections

    Since duplicate sections are allowed within openstack conf files,
    need to be able to handle them in some cases. The first case of
    this is in network where the ml2 conf is including the openvswitch
    conf within it and there are a couple dup sections. This
    allows the spec tests to handle those cases.

    Change-Id: I8d2733a248a6a13ab87c286ff620c71955726f86
    Closes-Bug: #1444696

Changed in openstack-chef:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers