[all] Use different URLs for internal/public endpoints (enhancement request)

[Ken Thomas]

Please let me know if this should be a blueprint instead and I'll be happy to write it up over there.

openstack_identity_register accepts three URLs when registering an endpoint, admin, internal, and public. Most of the components are using the same URL for both the public and internal endpoint.

For example...

https://github.com/stackforge/cookbook-openstack-image/blob/master/recipes/identity_registration.rb#L60
https://github.com/stackforge/cookbook-openstack-block-storage/blob/master/recipes/identity_registration.rb#L56
https://github.com/stackforge/cookbook-openstack-network/blob/master/recipes/identity_registration.rb#L59
https://github.com/stackforge/cookbook-openstack-compute/blob/master/recipes/identity_registration.rb#L90
etc.

We would like to add the ability to specify different URLs for the endpoints with the default behavior remaining as is. Perhaps an approach like the following....

(1) Add three new routines to https://github.com/stackforge/cookbook-openstack-common/blob/master/libraries/endpoints.rb for admin_endpoint, internal_endpoint, and public_endpoint that look for something like
node['openstack']['endpoints']['admin'][name]
or
node['openstack']['endpoints']['internal'][name]
or
node['openstack']['endpoints']['public'][name]

If the attribute doesn't exist, then default to what the endpoint routine does today by looking for nova['openstack']['endpoints'][name]

(2) In each component recipe, use the new routines in place of the endpoint routine and pass the values to openstack_identity_register.

If this sounds reasonable, then I'll be happy to work on it. If it doesn't sound reasonable, please let me know what we can do to avoid doing a local patch to the cookbooks. (This is a concern/requirement from our security group especially since we're already using different public/internal URLs with our non-chef deployments.)

[Mark Vanderwiel (vanderwl)]

this look reasonable to me. I like the #1 approach.

[Ken Thomas (krt)]

I've got the first part of the fix (adding the three new routines admin_endpoint, internal_endpoint, and public_endpoint) ready to submit for review, but... Even though it passes all of the existing (and new) unit tests. I'm wondering if there would be a problem with the "def endpoints(&block)" routine that iterates over all the endpoints. If there are new subsections for 'admin', 'internal', and 'public', is that going to have unexpected consequences? Should I update that routine to ignore those subsections if they exist?

[Mark Vanderwiel (vanderwl)]

Checkout my change here: https://review.openstack.org/#/c/148012/3/recipes/set_endpoints_by_interface.rb

Since we using the same namespace for "global" or "roll up" attributes, I decided to make that explicit in the recipe to avoid/skip any parents that are not really true endpoints.

[Ken Thomas (krt)]

Sounds like you're way ahead of me. ;) I'll get part 1 of the fix in today for review. I'll hold off on doing the component specific recipe changes until after we've worked out whatever issues come up during the review.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/149012

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/149012
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-common/commit/?id=0bd89832123afa196fe1c5fbd5a6e560616fe128
Submitter: Jenkins
Branch: master

commit 0bd89832123afa196fe1c5fbd5a6e560616fe128
Author: Ken Thomas <email address hidden>
Date: Wed Jan 21 17:32:19 2015 +0000

    Allow different URLs for internal/public endpoints

    Provide new endpoint routines for admin_endpoint, internal_endpoint,
    and public_endpoint. These will allow folks to specify different URLs
    for those endpoints if they wish.

    This is the first part of the fix. After the routines have been merged,
    I'll start working on using the routines in the various component
    recipies.

    Change-Id: I5b3b90324ee0f9bf6b2c5278ad60724856d43321
    Partial-Bug: 1412919

[Ken Thomas (krt)]

Now that the common changes have been merged, I'm going to start on the individual component cookbook changes. In case anybody wants to jump in, (to keep from getting in each other's way) I'm planning on starting with the following.... (I'll submit just one for review first just to make sure that the approach looks good before moving on to the rest.)

openstack-image
openstack-block-storage
openstack-orchestration

Just a FYI/reminder... we get to openstack-identity, we need to be careful since the public_endpoint is used in keystone.conf.erb[1] as well as in the call to openstack_identity_register[2]

[1] https://github.com/stackforge/cookbook-openstack-identity/blob/master/recipes/server.rb#L219
[2] https://github.com/stackforge/cookbook-openstack-identity/blob/master/recipes/registration.rb#L128

[Ken Thomas (krt)]

While working on the openstack-image tests, I found a bug in the common library that was just merged. It looks like having one 'admin' endpoint is masking other admin_endpoints from getting picked up from the general endpoint definition. The root cause the relying on the rescue statement inside of specific_endpoint in libraries/endpoints.rb Basically if there's a definition for ['endpoints']['admin']['foo'] then looking for *any* other 'admin' endpoint won't throw an exception and therefore won't get into the rescue path. That means that some other non-admin specific endpoint (E.g. ['endpoints']['bar']) which would normally get returned by admin_endpoint if there no admin specific definition, will now be ignored and admin_endpoint('bar') will return an empty string.

Fix is underway and will be checked in shortly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/150544

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/150544
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-common/commit/?id=8d73989865d6de84e5548c120b1379826910610b
Submitter: Jenkins
Branch: master

commit 8d73989865d6de84e5548c120b1379826910610b
Author: Ken Thomas <email address hidden>
Date: Tue Jan 27 18:44:22 2015 +0000

    specific_endpoint can return incorrect values

    There's a bug in the common library specific_endpoint routine that
    was just merged. If there's a defined endpoint for any one of the
    specified types ('internal', 'admin', 'public') it causes the code
    to incorrectly think that any name of that same type actually
    exists. This leads to an empty string being returned rather than
    picking up the general endpoint.

    For example:
    ['endpoints']['admin']['foo'] has been set
    ['endpoints']['bar'] has been set

    The admin_endpoint('bar') routine should see that there's no 'bar'
    under 'admin' and return the general endpoint. Instead, it's
    returning an empty string simply because there's an 'admin' subhash
    there for 'foo'.

    Change-Id: Ifd4ee6108b4c7b0f66bd56cc817b5ea646e82a68
    Partial-Bug: 1412919

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/151458

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/151474

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/151481

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/151738

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/151793

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/151800

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/152285

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/152289

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/151481
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-database/commit/?id=553ee424c853de55607be8d3e3733db69de02586
Submitter: Jenkins
Branch: master

commit 553ee424c853de55607be8d3e3733db69de02586
Author: Ken Thomas <email address hidden>
Date: Fri Jan 30 00:15:48 2015 +0000

    Use new common specific_endpoint routines

    Now that admin_endpoint, public_endpoint, and internal_endpoint
    in the common library are working, these are the changes to use
    them in the openstack-database recipes.

    Change-Id: Id90237f2ede9dee6afeb4ceb9dc23126ce35e05b
    Partial-Bug: 1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/151474
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-integration-test/commit/?id=8ef48dd064b387fbabf2ebe502c5cc07de85ebc4
Submitter: Jenkins
Branch: master

commit 8ef48dd064b387fbabf2ebe502c5cc07de85ebc4
Author: Ken Thomas <email address hidden>
Date: Thu Jan 29 23:55:34 2015 +0000

    Use new common specific_endpoint routines

    Now that admin_endpoint, public_endpoint, and internal_endpoint
    in the common library are working, these are the changes to use
    them in the openstack-integration-test recipes.

    No endpoints are created in these recipes, so no new tests
    were added.

    Change-Id: Ib38c9bf9675e688a8a4de7e7e8e04993eba57911
    Partial-Bug: 1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/151344
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-orchestration/commit/?id=aab5d086d8fc5fb957019bc22ee6459a797867fa
Submitter: Jenkins
Branch: master

commit aab5d086d8fc5fb957019bc22ee6459a797867fa
Author: Ken Thomas <email address hidden>
Date: Thu Jan 29 18:52:50 2015 +0000

    Use new common specific_endpoint routines

    Now that admin_endpoint, public_endpoint, and internal_endpoint
    in the common library are working, these are the changes to use
    them in the openstack-orchestration recipes.

    Partial-Bug: 1412919

    Change-Id: Ib89150c12ea833137b5f96c8ac5443c8aac364b4

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/151800
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-telemetry/commit/?id=dcaeffd75c40b379f6e9af998aa44abe94566e4e
Submitter: Jenkins
Branch: master

commit dcaeffd75c40b379f6e9af998aa44abe94566e4e
Author: Ken Thomas <email address hidden>
Date: Fri Jan 30 22:20:27 2015 +0000

    Use new common specific_endpoint routines

    Now that admin_endpoint, public_endpoint, and internal_endpoint
    in the common library are working, these are the changes to use
    them in the openstack-telemetry recipes.

    Change-Id: Ibddb87c1ae2e92c43c0b88495d363b6d8179d300
    Partial-Bug: 1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/151793
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-object-storage/commit/?id=93e4487124369bd68bc514e64f63c9ebd18fb527
Submitter: Jenkins
Branch: master

commit 93e4487124369bd68bc514e64f63c9ebd18fb527
Author: Ken Thomas <email address hidden>
Date: Fri Jan 30 21:44:37 2015 +0000

    Use new common specific_endpoint routines

    Now that admin_endpoint, public_endpoint, and internal_endpoint
    in the common library are working, these are the changes to use
    them in the openstack-object-storage recipes.

    Change-Id: Ia6a598bca2f0890ffa853e012dfdac08b51147c4
    Partial-Bug: 1412919

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/152672

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/152677

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/152681

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/152684

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/152289
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-compute/commit/?id=030642ec4ed947080571c9c4f1547da403c73267
Submitter: Jenkins
Branch: master

commit 030642ec4ed947080571c9c4f1547da403c73267
Author: Ken Thomas <email address hidden>
Date: Mon Feb 2 21:52:42 2015 +0000

    Use new common specific_endpoint routines

    Now that admin_endpoint, public_endpoint, and internal_endpoint
    in the common library are working, these are the changes to use
    them in the openstack-compute recipes.

    Change-Id: I4c90f4c7222f2f0b7fb7eba91f68e47841970e7c
    Partial-Bug: 1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/152681
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-database/commit/?id=36dab0f60191726612b41fe106cbea228541482a
Submitter: Jenkins
Branch: master

commit 36dab0f60191726612b41fe106cbea228541482a
Author: Ken Thomas <email address hidden>
Date: Tue Feb 3 21:12:43 2015 +0000

    Use identity-internal instead of public endpoint

    The discussion on using identity-internval vs the public
    identity-api endpoint can be found here:
    https://groups.google.com/forum/#!topic/opscode-chef-openstack/an9rydsrC0k

    Change-Id: I1a629b87251954bcebf4482e8a466759422f9f71
    Partial-Bug: 1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/151738
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-identity/commit/?id=45e824f3c175456779d3f714c1a6c1dd07e152b3
Submitter: Jenkins
Branch: master

commit 45e824f3c175456779d3f714c1a6c1dd07e152b3
Author: Ken Thomas <email address hidden>
Date: Fri Jan 30 19:00:11 2015 +0000

    Use new common specific_endpoint routines

    Now that admin_endpoint, public_endpoint, and internal_endpoint
    in the common library are working, these are the changes to use
    them in the openstack-identity recipes.

    This component already had different admin/internal/public
    endpoints and manages them by using different names. (E.g.
    'identity-admin', 'identity-internal', and 'identity-api')
    This means...

    1. No addition unit tests needed to be added. (No longer
       true. I went ahead and added some tests anyway.)

    2. We should probably have a clean up pass at some point
       where we use the newly added infrastructure for admin,
       internal, and public endpoints for a single service
       name. This could be a disruptive change so I propose
       that we defer that clean up for now.

    Change-Id: I27d0ffc5781028a450cdafcdf3db301ec3adc279
    Partial-Bug: 1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/152677
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-orchestration/commit/?id=89dd7aebdfb900f76c9260ef01f8354576832324
Submitter: Jenkins
Branch: master

commit 89dd7aebdfb900f76c9260ef01f8354576832324
Author: Ken Thomas <email address hidden>
Date: Tue Feb 3 21:03:46 2015 +0000

    Use identity-internal instead of public endpoint

    The discussion on using identity-internval vs the public
    identity-api endpoint can be found here:
    https://groups.google.com/forum/#!topic/opscode-chef-openstack/an9rydsrC0k

    Change-Id: Ibb937fa81aeaeba403775e78b76bdac348e05127
    Partial-Bug: 1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/152672
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-telemetry/commit/?id=013f010d554931a1f42951afff75b5b428c6aaf7
Submitter: Jenkins
Branch: master

commit 013f010d554931a1f42951afff75b5b428c6aaf7
Author: Ken Thomas <email address hidden>
Date: Tue Feb 3 20:36:01 2015 +0000

    Use identity-internal instead of public endpoint

    The discussion on using identity-internval vs the public
    identity-api endpoint can be found here:
    https://groups.google.com/forum/#!topic/opscode-chef-openstack/an9rydsrC0k

    Change-Id: Ic3a1b4914aeb095b4e9b37d5d4f4275bfa970edc
    Partial-Bug: 1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/151458
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-dashboard/commit/?id=9ce8d9d5a72f1c9062030872e6be4064dfd6a69a
Submitter: Jenkins
Branch: master

commit 9ce8d9d5a72f1c9062030872e6be4064dfd6a69a
Author: Ken Thomas <email address hidden>
Date: Thu Jan 29 22:59:33 2015 +0000

    Use new common specific_endpoint routines

    Now that admin_endpoint, public_endpoint, and internal_endpoint
    in the common library are working, these are the changes to use
    them in the openstack-dashboard recipes.

    Change-Id: I389476158d72107bf7079756518aba12fab7f52b
    Partial-Bug: 1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/152285
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-block-storage/commit/?id=b25e15d32da4bd62958b36c4700af1cc05ec0f80
Submitter: Jenkins
Branch: master

commit b25e15d32da4bd62958b36c4700af1cc05ec0f80
Author: Ken Thomas <email address hidden>
Date: Mon Feb 2 21:44:11 2015 +0000

    Use new common specific_endpoint routines

    Now that admin_endpoint, public_endpoint, and internal_endpoint
    in the common library are working, these are the changes to use
    them in the openstack-block-storge recipes.

    Change-Id: Ief4b9d011f55236270a4dc18f2b1f3f769d0a493
    Partial-Bug: 1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/152684
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-integration-test/commit/?id=24a9fd0cd7d827aff34dfb0a111cf03233495d43
Submitter: Jenkins
Branch: master

commit 24a9fd0cd7d827aff34dfb0a111cf03233495d43
Author: Ken Thomas <email address hidden>
Date: Tue Feb 3 21:20:38 2015 +0000

    Use identity-internal instead of public endpoint

    The discussion on using identity-internval vs the public
    identity-api endpoint can be found here:
    https://groups.google.com/forum/#!topic/opscode-chef-openstack/an9rydsrC0k

    Change-Id: I91f2253b3c471cdd25e025924da2899d732f96b8
    Partial-Bug: 1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/151414
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-network/commit/?id=2918234a399054ee054eece9da00007bcca9ba9d
Submitter: Jenkins
Branch: master

commit 2918234a399054ee054eece9da00007bcca9ba9d
Author: Ken Thomas <email address hidden>
Date: Thu Jan 29 22:46:52 2015 +0000

    Use new common specific_endpoint routines

    Now that admin_endpoint, public_endpoint, and internal_endpoint
    in the common library are working, these are the changes to use
    them in the openstack-network recipes.

    Note that some calls to 'endpoint' that can't have separate
    admin, internal, public endpoints. (E.g. network-api-bind,
    network-linuxbridge, network-openvswitch, etc.) Those
    will continue to use the general endpoint routine.

    Partial-Bug: 1412919

    Change-Id: Ia08983f6f8da8a96da22969cdb660b44f82780d6

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154138

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154139

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154142

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154146

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154148

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154149

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154151

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154153

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154154

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154156

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154159

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154163

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154195

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154159
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-integration-test/commit/?id=7dae9ff210af302d263bbcd4302ea1f3d4c26b78
Submitter: Jenkins
Branch: master

commit 7dae9ff210af302d263bbcd4302ea1f3d4c26b78
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 12:00:12 2015 -0600

    Missed bumping Common version

    Change-Id: I04e4c02675e39cb573aac95276de0b27e2354106
    Related-Bug: #1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154153
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-ops-database/commit/?id=67f1674bc54180fbf3a276dd6ec3c9253fb56c93
Submitter: Jenkins
Branch: master

commit 67f1674bc54180fbf3a276dd6ec3c9253fb56c93
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:51:05 2015 -0600

    Missed bumping Common version

    Change-Id: I2d706025e62c6ee4e5cf19af92fb590d780029a6
    Related-Bug: #1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154154
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-ops-messaging/commit/?id=d8d0322d5f8a7bc0c5c07b50de94ffe0f4132358
Submitter: Jenkins
Branch: master

commit d8d0322d5f8a7bc0c5c07b50de94ffe0f4132358
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:52:08 2015 -0600

    Missed bumping Common version

    Change-Id: Idbe24ccece58d9a12c66a425fa7a0ca4e1ad4353
    Related-Bug: #1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154142
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-database/commit/?id=d5c48b196525ae767a2c18fa1d0b45866dd12ef8
Submitter: Jenkins
Branch: master

commit d5c48b196525ae767a2c18fa1d0b45866dd12ef8
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:41:41 2015 -0600

    Missed bumping Common version

    Change-Id: I4166e91d02227c7bd3257962c1b730e21cab6634
    Related-Bug: #1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154146
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-identity/commit/?id=170afa54fd2ee5688857f91bd471592975262c0a
Submitter: Jenkins
Branch: master

commit 170afa54fd2ee5688857f91bd471592975262c0a
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:45:46 2015 -0600

    Missed bumping Common version

    Change-Id: If506827dc24d4a31d5b0473dd2531b66dd91a703
    Related-Bug: #1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154195
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-dashboard/commit/?id=f54509245be0dc997d0880e53f99dd271bb4e172
Submitter: Jenkins
Branch: master

commit f54509245be0dc997d0880e53f99dd271bb4e172
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:43:46 2015 -0600

    Missed bumping Common version

    Change-Id: Id6937615db1d646a518e8ada51f6586bd103d05d
    Related-Bug: #1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154156
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-orchestration/commit/?id=04c09fbf126be12586edda36efe29ce8b8fdb552
Submitter: Jenkins
Branch: master

commit 04c09fbf126be12586edda36efe29ce8b8fdb552
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:53:05 2015 -0600

    Missed bumping Common version

    Change-Id: I6e97f184b4c7cf1d56127096eb614d104f221a73
    Related-Bug: #1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154149
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-object-storage/commit/?id=37d2d617945c3e77102882a9f3d40e85981dd75e
Submitter: Jenkins
Branch: master

commit 37d2d617945c3e77102882a9f3d40e85981dd75e
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:48:15 2015 -0600

    Missed bumping Common version

    Change-Id: Ib87f895b2f194c97e6f028d6e857ed644b0358b3
    Related-Bug: #1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154163
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-telemetry/commit/?id=3df092ef045a999c862ae1219955ba7785bf9d11
Submitter: Jenkins
Branch: master

commit 3df092ef045a999c862ae1219955ba7785bf9d11
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 12:03:19 2015 -0600

    Missed bumping Common version

    Change-Id: Icf83059f8fdb465c2c72e0233777c9844d530f32
    Related-Bug: #1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154138
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-block-storage/commit/?id=aa93aa966362c87c0addeece104649f3e702aa18
Submitter: Jenkins
Branch: master

commit aa93aa966362c87c0addeece104649f3e702aa18
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:35:46 2015 -0600

    Missed bumping Common version

    Change-Id: I4c557d75a803263cbcd0f3a22f9628b35ab4941e
    Related-Bug: #1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154148
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-image/commit/?id=cc7dddbd7a13c3b564f2d09c1c69ee6eaa15de0b
Submitter: Jenkins
Branch: master

commit cc7dddbd7a13c3b564f2d09c1c69ee6eaa15de0b
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:46:46 2015 -0600

    Missed bumping Common version

    Change-Id: Ia9317e28a36c1a17ac52b0dd3f2d3d724756c347
    Related-Bug: #1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154151
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-network/commit/?id=59f67f104a4f19a3103ae97f3aba2e06e9c306ed
Submitter: Jenkins
Branch: master

commit 59f67f104a4f19a3103ae97f3aba2e06e9c306ed
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:49:25 2015 -0600

    Missed bumping Common version

    Change-Id: Idd5920424e1c2011ce01590ccfdfae332377e144
    Related-Bug: #1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154139
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-compute/commit/?id=c702cc41a0c87c33e21acdac9108a03f96eef196
Submitter: Jenkins
Branch: master

commit c702cc41a0c87c33e21acdac9108a03f96eef196
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:37:23 2015 -0600

    Missed bumping Common version

    Change-Id: Id2742ca615a9d82fdf129a92f97e65a6af849b5a
    Related-Bug: #1412919

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/150559
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-image/commit/?id=31e7f0d2328cdea95d6d3de35123ad54828401ed
Submitter: Jenkins
Branch: master

commit 31e7f0d2328cdea95d6d3de35123ad54828401ed
Author: Ken Thomas <email address hidden>
Date: Tue Jan 27 19:31:10 2015 +0000

    Use new common specific_endpoint routines

    Now that admin_endpoint, public_endpoint, and internal_endpoint
    in the common library are (nearly) working, these are the
    changes to use them in the openstack-image recipes.

    Partial-Bug: 1412919

    Change-Id: If81fc2a56f540a460325de879555e95d108aac77

[Mark Vanderwiel (vanderwl)]

This one considered done now?

[Ken Thomas (krt)]

I'm happy with it. If every one else is too, then I'm all for marking it "fixed released".