[all] Use different URLs for internal/public endpoints (enhancement request)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack + Chef |
Fix Released
|
Medium
|
Ken Thomas |
Bug Description
Please let me know if this should be a blueprint instead and I'll be happy to write it up over there.
openstack_
For example...
https:/
https:/
https:/
https:/
etc.
We would like to add the ability to specify different URLs for the endpoints with the default behavior remaining as is. Perhaps an approach like the following....
(1) Add three new routines to https:/
node['openstack
or
node['openstack
or
node['openstack
If the attribute doesn't exist, then default to what the endpoint routine does today by looking for nova['openstack
(2) In each component recipe, use the new routines in place of the endpoint routine and pass the values to openstack_
If this sounds reasonable, then I'll be happy to work on it. If it doesn't sound reasonable, please let me know what we can do to avoid doing a local patch to the cookbooks. (This is a concern/requirement from our security group especially since we're already using different public/internal URLs with our non-chef deployments.)
Ken Thomas (krt) wrote : | #2 |
I've got the first part of the fix (adding the three new routines admin_endpoint, internal_endpoint, and public_endpoint) ready to submit for review, but... Even though it passes all of the existing (and new) unit tests. I'm wondering if there would be a problem with the "def endpoints(&block)" routine that iterates over all the endpoints. If there are new subsections for 'admin', 'internal', and 'public', is that going to have unexpected consequences? Should I update that routine to ignore those subsections if they exist?
description: | updated |
Mark Vanderwiel (vanderwl) wrote : | #3 |
Checkout my change here: https:/
Since we using the same namespace for "global" or "roll up" attributes, I decided to make that explicit in the recipe to avoid/skip any parents that are not really true endpoints.
Ken Thomas (krt) wrote : | #4 |
Sounds like you're way ahead of me. ;) I'll get part 1 of the fix in today for review. I'll hold off on doing the component specific recipe changes until after we've worked out whatever issues come up during the review.
Changed in openstack-chef: | |
assignee: | nobody → Ken Thomas (krt) |
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-common (master) | #5 |
Fix proposed to branch: master
Review: https:/
Changed in openstack-chef: | |
status: | New → In Progress |
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-common (master) | #6 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 0bd89832123afa1
Author: Ken Thomas <email address hidden>
Date: Wed Jan 21 17:32:19 2015 +0000
Allow different URLs for internal/public endpoints
Provide new endpoint routines for admin_endpoint, internal_endpoint,
and public_endpoint. These will allow folks to specify different URLs
for those endpoints if they wish.
This is the first part of the fix. After the routines have been merged,
I'll start working on using the routines in the various component
recipies.
Change-Id: I5b3b90324ee0f9
Partial-Bug: 1412919
Ken Thomas (krt) wrote : | #7 |
Now that the common changes have been merged, I'm going to start on the individual component cookbook changes. In case anybody wants to jump in, (to keep from getting in each other's way) I'm planning on starting with the following.... (I'll submit just one for review first just to make sure that the approach looks good before moving on to the rest.)
openstack-image
openstack-
openstack-
Just a FYI/reminder... we get to openstack-identity, we need to be careful since the public_endpoint is used in keystone.
[1] https:/
[2] https:/
Ken Thomas (krt) wrote : | #8 |
While working on the openstack-image tests, I found a bug in the common library that was just merged. It looks like having one 'admin' endpoint is masking other admin_endpoints from getting picked up from the general endpoint definition. The root cause the relying on the rescue statement inside of specific_endpoint in libraries/
Fix is underway and will be checked in shortly.
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-common (master) | #9 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-common (master) | #10 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 8d73989865d6de8
Author: Ken Thomas <email address hidden>
Date: Tue Jan 27 18:44:22 2015 +0000
specific_
There's a bug in the common library specific_endpoint routine that
was just merged. If there's a defined endpoint for any one of the
specified types ('internal', 'admin', 'public') it causes the code
to incorrectly think that any name of that same type actually
exists. This leads to an empty string being returned rather than
picking up the general endpoint.
For example:
['endpoints
['endpoints
The admin_endpoint(
under 'admin' and return the general endpoint. Instead, it's
returning an empty string simply because there's an 'admin' subhash
there for 'foo'.
Change-Id: Ifd4ee6108b4c7b
Partial-Bug: 1412919
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-dashboard (master) | #11 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-integration-test (master) | #12 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-database (master) | #13 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-identity (master) | #14 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-object-storage (master) | #15 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-telemetry (master) | #16 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-block-storage (master) | #17 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-compute (master) | #18 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-database (master) | #19 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 553ee424c853de5
Author: Ken Thomas <email address hidden>
Date: Fri Jan 30 00:15:48 2015 +0000
Use new common specific_endpoint routines
Now that admin_endpoint, public_endpoint, and internal_endpoint
in the common library are working, these are the changes to use
them in the openstack-database recipes.
Change-Id: Id90237f2ede9de
Partial-Bug: 1412919
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-integration-test (master) | #20 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 8ef48dd064b387f
Author: Ken Thomas <email address hidden>
Date: Thu Jan 29 23:55:34 2015 +0000
Use new common specific_endpoint routines
Now that admin_endpoint, public_endpoint, and internal_endpoint
in the common library are working, these are the changes to use
them in the openstack-
No endpoints are created in these recipes, so no new tests
were added.
Change-Id: Ib38c9bf9675e68
Partial-Bug: 1412919
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-orchestration (master) | #21 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit aab5d086d8fc5fb
Author: Ken Thomas <email address hidden>
Date: Thu Jan 29 18:52:50 2015 +0000
Use new common specific_endpoint routines
Now that admin_endpoint, public_endpoint, and internal_endpoint
in the common library are working, these are the changes to use
them in the openstack-
Partial-Bug: 1412919
Change-Id: Ib89150c12ea833
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-telemetry (master) | #22 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit dcaeffd75c40b37
Author: Ken Thomas <email address hidden>
Date: Fri Jan 30 22:20:27 2015 +0000
Use new common specific_endpoint routines
Now that admin_endpoint, public_endpoint, and internal_endpoint
in the common library are working, these are the changes to use
them in the openstack-telemetry recipes.
Change-Id: Ibddb87c1ae2e92
Partial-Bug: 1412919
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-object-storage (master) | #23 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 93e4487124369bd
Author: Ken Thomas <email address hidden>
Date: Fri Jan 30 21:44:37 2015 +0000
Use new common specific_endpoint routines
Now that admin_endpoint, public_endpoint, and internal_endpoint
in the common library are working, these are the changes to use
them in the openstack-
Change-Id: Ia6a598bca2f089
Partial-Bug: 1412919
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-telemetry (master) | #24 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-orchestration (master) | #25 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-database (master) | #26 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-integration-test (master) | #27 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-compute (master) | #28 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 030642ec4ed9470
Author: Ken Thomas <email address hidden>
Date: Mon Feb 2 21:52:42 2015 +0000
Use new common specific_endpoint routines
Now that admin_endpoint, public_endpoint, and internal_endpoint
in the common library are working, these are the changes to use
them in the openstack-compute recipes.
Change-Id: I4c90f4c7222f2f
Partial-Bug: 1412919
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-database (master) | #29 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 36dab0f60191726
Author: Ken Thomas <email address hidden>
Date: Tue Feb 3 21:12:43 2015 +0000
Use identity-internal instead of public endpoint
The discussion on using identity-internval vs the public
identity-api endpoint can be found here:
https:/
Change-Id: I1a629b87251954
Partial-Bug: 1412919
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-identity (master) | #30 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 45e824f3c175456
Author: Ken Thomas <email address hidden>
Date: Fri Jan 30 19:00:11 2015 +0000
Use new common specific_endpoint routines
Now that admin_endpoint, public_endpoint, and internal_endpoint
in the common library are working, these are the changes to use
them in the openstack-identity recipes.
This component already had different admin/internal/
endpoints and manages them by using different names. (E.g.
'identity-
This means...
1. No addition unit tests needed to be added. (No longer
true. I went ahead and added some tests anyway.)
2. We should probably have a clean up pass at some point
where we use the newly added infrastructure for admin,
internal, and public endpoints for a single service
name. This could be a disruptive change so I propose
that we defer that clean up for now.
Change-Id: I27d0ffc5781028
Partial-Bug: 1412919
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-orchestration (master) | #31 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 89dd7aebdfb900f
Author: Ken Thomas <email address hidden>
Date: Tue Feb 3 21:03:46 2015 +0000
Use identity-internal instead of public endpoint
The discussion on using identity-internval vs the public
identity-api endpoint can be found here:
https:/
Change-Id: Ibb937fa81aeaeb
Partial-Bug: 1412919
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-telemetry (master) | #32 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 013f010d554931a
Author: Ken Thomas <email address hidden>
Date: Tue Feb 3 20:36:01 2015 +0000
Use identity-internal instead of public endpoint
The discussion on using identity-internval vs the public
identity-api endpoint can be found here:
https:/
Change-Id: Ic3a1b4914aeb09
Partial-Bug: 1412919
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-dashboard (master) | #33 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 9ce8d9d5a72f1c9
Author: Ken Thomas <email address hidden>
Date: Thu Jan 29 22:59:33 2015 +0000
Use new common specific_endpoint routines
Now that admin_endpoint, public_endpoint, and internal_endpoint
in the common library are working, these are the changes to use
them in the openstack-dashboard recipes.
Change-Id: I389476158d7210
Partial-Bug: 1412919
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-block-storage (master) | #34 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit b25e15d32da4bd6
Author: Ken Thomas <email address hidden>
Date: Mon Feb 2 21:44:11 2015 +0000
Use new common specific_endpoint routines
Now that admin_endpoint, public_endpoint, and internal_endpoint
in the common library are working, these are the changes to use
them in the openstack-
Change-Id: Ief4b9d011f5523
Partial-Bug: 1412919
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-integration-test (master) | #35 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 24a9fd0cd7d827a
Author: Ken Thomas <email address hidden>
Date: Tue Feb 3 21:20:38 2015 +0000
Use identity-internal instead of public endpoint
The discussion on using identity-internval vs the public
identity-api endpoint can be found here:
https:/
Change-Id: I91f2253b3c471c
Partial-Bug: 1412919
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-network (master) | #36 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 2918234a399054e
Author: Ken Thomas <email address hidden>
Date: Thu Jan 29 22:46:52 2015 +0000
Use new common specific_endpoint routines
Now that admin_endpoint, public_endpoint, and internal_endpoint
in the common library are working, these are the changes to use
them in the openstack-network recipes.
Note that some calls to 'endpoint' that can't have separate
admin, internal, public endpoints. (E.g. network-api-bind,
network-
will continue to use the general endpoint routine.
Partial-Bug: 1412919
Change-Id: Ia08983f6f8da8a
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cookbook-openstack-block-storage (master) | #37 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cookbook-openstack-compute (master) | #38 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cookbook-openstack-database (master) | #39 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cookbook-openstack-identity (master) | #40 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cookbook-openstack-image (master) | #41 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cookbook-openstack-object-storage (master) | #42 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cookbook-openstack-network (master) | #43 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cookbook-openstack-ops-database (master) | #44 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cookbook-openstack-ops-messaging (master) | #45 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cookbook-openstack-orchestration (master) | #46 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cookbook-openstack-integration-test (master) | #47 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cookbook-openstack-telemetry (master) | #48 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cookbook-openstack-dashboard (master) | #49 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cookbook-openstack-integration-test (master) | #50 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 7dae9ff210af302
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 12:00:12 2015 -0600
Missed bumping Common version
Change-Id: I04e4c02675e39c
Related-Bug: #1412919
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cookbook-openstack-ops-database (master) | #51 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 67f1674bc54180f
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:51:05 2015 -0600
Missed bumping Common version
Change-Id: I2d706025e62c6e
Related-Bug: #1412919
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cookbook-openstack-ops-messaging (master) | #52 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit d8d0322d5f8a7bc
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:52:08 2015 -0600
Missed bumping Common version
Change-Id: Idbe24ccece58d9
Related-Bug: #1412919
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cookbook-openstack-database (master) | #53 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit d5c48b196525ae7
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:41:41 2015 -0600
Missed bumping Common version
Change-Id: I4166e91d02227c
Related-Bug: #1412919
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cookbook-openstack-identity (master) | #54 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 170afa54fd2ee56
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:45:46 2015 -0600
Missed bumping Common version
Change-Id: If506827dc24d4a
Related-Bug: #1412919
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cookbook-openstack-dashboard (master) | #55 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit f54509245be0dc9
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:43:46 2015 -0600
Missed bumping Common version
Change-Id: Id6937615db1d64
Related-Bug: #1412919
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cookbook-openstack-orchestration (master) | #56 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 04c09fbf126be12
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:53:05 2015 -0600
Missed bumping Common version
Change-Id: I6e97f184b4c7cf
Related-Bug: #1412919
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cookbook-openstack-object-storage (master) | #57 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 37d2d617945c3e7
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:48:15 2015 -0600
Missed bumping Common version
Change-Id: Ib87f895b2f194c
Related-Bug: #1412919
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cookbook-openstack-telemetry (master) | #58 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 3df092ef045a999
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 12:03:19 2015 -0600
Missed bumping Common version
Change-Id: Icf83059f8fdb46
Related-Bug: #1412919
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cookbook-openstack-block-storage (master) | #59 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit aa93aa966362c87
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:35:46 2015 -0600
Missed bumping Common version
Change-Id: I4c557d75a80326
Related-Bug: #1412919
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cookbook-openstack-image (master) | #60 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit cc7dddbd7a13c3b
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:46:46 2015 -0600
Missed bumping Common version
Change-Id: Ia9317e28a36c1a
Related-Bug: #1412919
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cookbook-openstack-network (master) | #61 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 59f67f104a4f19a
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:49:25 2015 -0600
Missed bumping Common version
Change-Id: Idd5920424e1c20
Related-Bug: #1412919
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cookbook-openstack-compute (master) | #62 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit c702cc41a0c87c3
Author: Mark Vanderwiel <email address hidden>
Date: Mon Feb 9 11:37:23 2015 -0600
Missed bumping Common version
Change-Id: Id2742ca615a9d8
Related-Bug: #1412919
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-image (master) | #63 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 31e7f0d2328cdea
Author: Ken Thomas <email address hidden>
Date: Tue Jan 27 19:31:10 2015 +0000
Use new common specific_endpoint routines
Now that admin_endpoint, public_endpoint, and internal_endpoint
in the common library are (nearly) working, these are the
changes to use them in the openstack-image recipes.
Partial-Bug: 1412919
Change-Id: If81fc2a56f540a
Mark Vanderwiel (vanderwl) wrote : | #64 |
This one considered done now?
Changed in openstack-chef: | |
importance: | Undecided → Medium |
Ken Thomas (krt) wrote : | #65 |
I'm happy with it. If every one else is too, then I'm all for marking it "fixed released".
Changed in openstack-chef: | |
status: | In Progress → Fix Released |
milestone: | none → juno-stable |
this look reasonable to me. I like the #1 approach.