[all] cleanup Gemfile

Bug #1411473 reported by zhiwei
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack + Chef
Fix Released
Low
zhiwei

Bug Description

For there are some gems like rake is not necessary, so I'd like to remove them in Gemfile.

Maybe there are other gems that also unnecessary or unnecessary to put them to Gemfile.

Even if you remove them from Gemfile, they will be always installed when running `bundle install`.

But just want to keep the Gemfile clean, and only specify the exactly version of gems to resolve constraints issue.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/147747

Changed in openstack-chef:
assignee: nobody → zhiwei (chenzhiwei)
status: New → In Progress
zhiwei (chenzhiwei)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-block-storage (master)

Fix proposed to branch: master
Review: https://review.openstack.org/147748

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-identity (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148146

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-image (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148148

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-network (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148149

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-ops-database (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148150

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-ops-messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148151

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-orchestration (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148153

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-telemetry (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148154

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-integration-test (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148170

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148190

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-object-storage (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148191

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-database (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148193

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-ops-database (master)

Reviewed: https://review.openstack.org/148150
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-ops-database/commit/?id=8cfb12b4d4791ccd01310c4b8f2f775d95d67f8d
Submitter: Jenkins
Branch: master

commit 8cfb12b4d4791ccd01310c4b8f2f775d95d67f8d
Author: Chen Zhiwei <email address hidden>
Date: Mon Jan 19 09:38:35 2015 +0800

    Remove rake from Gemfile

    Change-Id: I53da377f4ec2c7a305f19482e31901689b3436c4
    Partial-Bug: #1411473

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-ops-messaging (master)

Reviewed: https://review.openstack.org/148151
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-ops-messaging/commit/?id=dadf0931c657688087f8affae45b2c1ebdf94c9e
Submitter: Jenkins
Branch: master

commit dadf0931c657688087f8affae45b2c1ebdf94c9e
Author: Chen Zhiwei <email address hidden>
Date: Mon Jan 19 09:40:07 2015 +0800

    Remove rake from Gemfile

    Change-Id: I54543c7e590bf886493e8db098f215c508490f46
    Partial-Bug: #1411473

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-database (master)

Reviewed: https://review.openstack.org/148193
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-database/commit/?id=083b995fee8e2f6400264f2599b659eb5c8232d2
Submitter: Jenkins
Branch: master

commit 083b995fee8e2f6400264f2599b659eb5c8232d2
Author: Chen Zhiwei <email address hidden>
Date: Mon Jan 19 15:38:18 2015 +0800

    Remove rake from Gemfile

    Change-Id: I238e4551c0b679479a247739f53f7b61b879d499
    Partial-Bug: #1411473

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-orchestration (master)

Reviewed: https://review.openstack.org/148153
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-orchestration/commit/?id=197e54735fa5fb1effcce72236a485899d996212
Submitter: Jenkins
Branch: master

commit 197e54735fa5fb1effcce72236a485899d996212
Author: Chen Zhiwei <email address hidden>
Date: Mon Jan 19 09:43:12 2015 +0800

    Remove rake from Gemfile

    Change-Id: Iac3e3490c7218b032e41fd34d29a33d18ad93036
    Partial-Bug: #1411473

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-telemetry (master)

Reviewed: https://review.openstack.org/148154
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-telemetry/commit/?id=04a01ac6ac83818008cc42d39757466af69397c2
Submitter: Jenkins
Branch: master

commit 04a01ac6ac83818008cc42d39757466af69397c2
Author: Chen Zhiwei <email address hidden>
Date: Mon Jan 19 09:45:20 2015 +0800

    Remove rake from Gemfile

    Change-Id: I7d951bb0927b5d68581166d2cd6e44d345357404
    Partial-Bug: #1411473

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-integration-test (master)

Reviewed: https://review.openstack.org/148170
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-integration-test/commit/?id=d10511d87527bdbf442c5c1c5a1785df629e1d22
Submitter: Jenkins
Branch: master

commit d10511d87527bdbf442c5c1c5a1785df629e1d22
Author: Chen Zhiwei <email address hidden>
Date: Mon Jan 19 13:15:09 2015 +0800

    Remove rake from Gemfile

    Change-Id: Ie0be1547e44fc0f67f90f90297c755b2d2a22f95
    Partial-Bug: #1411473

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-identity (master)

Reviewed: https://review.openstack.org/148146
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-identity/commit/?id=ac563e207acd5ea0a3412803cbeceb8d7808bbfc
Submitter: Jenkins
Branch: master

commit ac563e207acd5ea0a3412803cbeceb8d7808bbfc
Author: Chen Zhiwei <email address hidden>
Date: Mon Jan 19 09:31:14 2015 +0800

    Remove rake from Gemfile

    Change-Id: I8b7dc2ec2bbf8a63ebf191502503e368734d7c28
    Partial-Bug: #1411473

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-image (master)

Reviewed: https://review.openstack.org/148148
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-image/commit/?id=26b05d678f3220c8542c79be8ebb13770b4c8e48
Submitter: Jenkins
Branch: master

commit 26b05d678f3220c8542c79be8ebb13770b4c8e48
Author: Chen Zhiwei <email address hidden>
Date: Mon Jan 19 09:33:22 2015 +0800

    Remove rake from Gemfile

    Change-Id: I00d4558bc9cd99766654a518cebf65c7eb36f40c
    Partial-Bug: #1411473

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-object-storage (master)

Reviewed: https://review.openstack.org/148191
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-object-storage/commit/?id=a852b9eb09c5a3502f4a974fb61f28882f4a8e25
Submitter: Jenkins
Branch: master

commit a852b9eb09c5a3502f4a974fb61f28882f4a8e25
Author: Chen Zhiwei <email address hidden>
Date: Mon Jan 19 15:27:31 2015 +0800

    Remove rake from Gemfile

    Change-Id: I05ee4015135dd75517da8affeac3014b7b39d159
    Partial-Bug: #1411473

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-dashboard (master)

Reviewed: https://review.openstack.org/148190
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-dashboard/commit/?id=e222e7b5c1cf74e0682b45b8fc227b12c264c6c8
Submitter: Jenkins
Branch: master

commit e222e7b5c1cf74e0682b45b8fc227b12c264c6c8
Author: Chen Zhiwei <email address hidden>
Date: Mon Jan 19 15:22:58 2015 +0800

    Remove rake from Gemfile

    Change-Id: I8dd66a9e512d8959e2d982c2e0bcf54d4b9dda06
    Partial-Bug: #1411473

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-network (master)

Reviewed: https://review.openstack.org/148149
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-network/commit/?id=8ba675199d5ab56313685aa64b5dc09719e85102
Submitter: Jenkins
Branch: master

commit 8ba675199d5ab56313685aa64b5dc09719e85102
Author: Chen Zhiwei <email address hidden>
Date: Mon Jan 19 09:37:05 2015 +0800

    Remove rake from Gemfile

    Change-Id: I1f59b775aca7f5583d118bd269908dc6e59f60a1
    Partial-Bug: #1411473

Revision history for this message
JJ Asghar (d-jj) wrote : Re: cleanup Gemfile

The rake tasks we are building require rake.

Revision history for this message
zhiwei (chenzhiwei) wrote :

Oh, sorry.

In this commit: https://review.openstack.org/#/c/137134/12/jenkins/jobs/macros.yaml

Line 203 installs rake by `sudo gem install rake --no-rdoc --no-ri --verbose`.

But in line 226, it uses `bundle exec rake test` command to run the test.

There are two solutions:

1. Update infra config project to replace `bundle exec rake test` by `rake test`.

2. Remove the install rake part and add rake to Gemfile back.

I am very sorry for this, I only knew that the rake was installed in infra project, but it was not used.

For now it's ok for our case, because there are other gems that depends on rake, even we did not specify rake in Gemfile it will be still installed.

I think we need to add rake back to Gemfile and remove the install rake command in infra project.

Revision history for this message
Jan Klare (j-klare) wrote :

Patch for updating the infra config is in (https://review.openstack.org/#/c/148465/)

Revision history for this message
zhiwei (chenzhiwei) wrote :

My comment #26 is not correct, bundler command is driven by rake. So must install rake and bundler before run rake command.

So, there is only one solutioin, update infra config project to replace `bundle exec rake test` by `rake test`.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-common (master)

Reviewed: https://review.openstack.org/147747
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-common/commit/?id=cd71d1324a3c5fff94b13ba87c8df235608a5ce8
Submitter: Jenkins
Branch: master

commit cd71d1324a3c5fff94b13ba87c8df235608a5ce8
Author: Chen Zhiwei <email address hidden>
Date: Fri Jan 16 12:52:30 2015 +0800

    Remove rake and strainer from Gemfile

    Change-Id: Id2c35cdb811d87964a4e2f9d1a8a05146b045309
    Partial-Bug: #1411473

zhiwei (chenzhiwei)
Changed in openstack-chef:
importance: Undecided → Low
summary: - cleanup Gemfile
+ [all] cleanup Gemfile
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-block-storage (master)

Reviewed: https://review.openstack.org/147748
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-block-storage/commit/?id=7d6e0a866a19319f0a079c75abe4fd8fa65dcf41
Submitter: Jenkins
Branch: master

commit 7d6e0a866a19319f0a079c75abe4fd8fa65dcf41
Author: Chen Zhiwei <email address hidden>
Date: Fri Jan 16 13:06:07 2015 +0800

    Remove rake from Gemfile

    Change-Id: I6f424b11c4df3424e294f48d0ad367a1a5daf12f
    Partial-Bug: #1411473

Changed in openstack-chef:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.