[block-storage] gpfs driver is setting "gpfs_images_share_mode" even though "gpfs_images_dir" is not defined

[Sasikanth Eda]

Hi,

From the cinder documentation (http://docs.openstack.org/trunk/config-reference/content/GPFS-driver-options.html),
the variable "gpfs_images_share_mode" needs to be set only if the varaible "gpfs_images_dir" is defined.

With the current code, "gpfs_images_share_mode" is getting set to "copy" even if "gpfs_images_dir" is not defined. As a result of this cinder reports driver initialization errors.

[Nilesh Bhosale (nilesh-bhosale)]

For the option 'gpfs_images_share_mode', the documentation says: "... Set this when the Image service repository also uses GPFS so that image files can be transferred efficiently from the Image service to the Block Storage service." That actually means, set 'gpfs_images_share_mode' when 'gpfs_images_dir' is set and not 'None'. So in a sense this is covered, although it would be better to make it more explicit in the docs.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/133163

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/133163
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-block-storage/commit/?id=cf9ec63b94144e882c7f9b724fad14e7d921c4e3
Submitter: Jenkins
Branch: master

commit cf9ec63b94144e882c7f9b724fad14e7d921c4e3
Author: Sasikanth <email address hidden>
Date: Fri Nov 7 13:42:46 2014 +0530

    Update gpfs volume driver path

    * Change of driver path from "drivers.gpfs.GPFSDriver" to
      "drivers.ibm.gpfs.GPFSDriver"
    * Fix issue of assigning "gpfs_images_share_mode=copy_on_write"
      even if the parent attribute "gpfs_images_dir" is not defined

    Change-Id: Ica00f00901502857d5d21ef7ce7ae3b68e4ca9b7
    Closes-Bug: #1389955