[compute] Need separate endpoints for vncserver_listen and vncserver_proxyclient_address

[Mark Vanderwiel]

Allow the nova.conf vncserver_listen and vncserver_proxyclient_address options to be configured using different endpoint attributes to enable support for both live migration and and dashboard console vnc access.

Current logic in compute nova-common recipe:

vnc_bind = endpoint 'compute-vnc-bind' || {}
...
template '/etc/nova/nova.conf' do
...
  variables(
...
    vncserver_listen: vnc_bind.host,
    vncserver_proxyclient_address: vnc_bind.host,
...
  )
end

These are the currently defined compute vnc endpoints in Common:

# The OpenStack Compute (Nova) vnc endpoint
default['openstack']['endpoints']['compute-vnc-bind']['host'] = node['openstack']['endpoints']['bind-host']
default['openstack']['endpoints']['compute-vnc-bind']['bind_interface'] = nil

default['openstack']['endpoints']['compute-vnc']['host'] = node['openstack']['endpoints']['host']
default['openstack']['endpoints']['compute-vnc']['scheme'] = nil
default['openstack']['endpoints']['compute-vnc']['port'] = nil
default['openstack']['endpoints']['compute-vnc']['path'] = nil
default['openstack']['endpoints']['compute-vnc']['bind_interface'] = nil

There is no way to have a different address specified for the proxyclient.

Propose to have a new bind attribute based off the existing one as follows:

# The OpenStack Compute (Nova) vnc server proxy endpoint
default['openstack']['endpoints']['compute-vnc-proxy-bind']['host'] = node['openstack']['endpoints']['compute-vnc-bind']['host']
default['openstack']['endpoints']['compute-vnc-proxy-bind']['bind_interface'] = node['openstack']['endpoints']['compute-vnc-bind']['bind_interface']

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/120473

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/120474

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/120474
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-common/commit/?id=6a44710656f618c1363f0b9372bccd2a6f4d07ec
Submitter: Jenkins
Branch: master

commit 6a44710656f618c1363f0b9372bccd2a6f4d07ec
Author: Mark Vanderwiel <email address hidden>
Date: Wed Sep 10 11:15:54 2014 -0500

    Separate endpoints for vncserver_listen and vncserver_proxyclient_address

    * define new endpoint for proxy based on existing vnc endpoint
    * will be used in Compute nova-common recipe for nova.conf

    Change-Id: I89298db2461b59ab8038dfc01d42f0eb69a8b58c
    Partial-Bug: #1367807

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/120473
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-compute/commit/?id=a80dc09214e1d7f02ec6d27a264193424f1fc0d7
Submitter: Jenkins
Branch: master

commit a80dc09214e1d7f02ec6d27a264193424f1fc0d7
Author: Mark Vanderwiel <email address hidden>
Date: Wed Sep 10 11:19:25 2014 -0500

    Separate endpoints for vncserver_listen and vncserver_proxyclient_address

    * A patch for Common added a new endpoint for vnc proxy
    * Use the new vnc proxy endpoint for the nova.conf

    Change-Id: I9909e3dd500d9fcc31133b81c93420b629ed4e37
    Closes-Bug: #1367807