[Identity] InternalURL should point to public endpoint.

Bug #1356732 reported by Sachi King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack + Chef
Fix Released
Undecided
Sachi King

Bug Description

What appears to be a small typo in the registration recipe is passing "AdminURL" to the "InternalURL" option for creation of the endpoints in keystone.

The variable "InternalURL" is defined earlier and is the appropriate value to be passed.

The Internal URL endpoint is used by OpenStack services such as Dashboard to connect to keystone. In certain cases the admin pipeline does not have the appropriate features to handle requests coming from them, such as UserCRUD.

Tags: internalurl
Changed in openstack-chef:
assignee: nobody → Sachi King (nakato)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-identity (master)

Reviewed: https://review.openstack.org/113734
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-identity/commit/?id=552488824aa720f08249bc4d19f5224e9382aa00
Submitter: Jenkins
Branch: master

commit 552488824aa720f08249bc4d19f5224e9382aa00
Author: Sachi King <email address hidden>
Date: Wed Aug 13 10:37:04 2014 +1000

    internalURL should use the internalURL variable

    This patches what appears to be a typo where the internalURL passed to
    openstack_identity_register with the "adminURL" variable instead of the
    internalURL variable that is defined earlier in the code.

    This was noticed as the cookbook was setting up the endpoints with the
    internalURL defined to the admin endpoint. This is opposite to
    OpenStack documentation and breaks operations of other openstack
    projects which rely on internalURL. For example the admin pipeline does
    not have user_CRUD, while the public one does, breaking dashboard.

    Following the inclusion of this patch the identity-internal endpoint
    will need to be added to cookbook-chef-common. Following that addition
    the number of node.set for the identity-internal endpoint can be
    reduced.

    Partial-Bug: #1356732

    Change-Id: I4bc3d49fd15b7254976a5ed8e964a4b3e3af02c6

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/115889

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-identity (master)

Fix proposed to branch: master
Review: https://review.openstack.org/117108

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-common (master)

Reviewed: https://review.openstack.org/115889
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-common/commit/?id=e47321b3c798ba4300e2affacd29502b35dc12d5
Submitter: Jenkins
Branch: master

commit e47321b3c798ba4300e2affacd29502b35dc12d5
Author: Sachi King <email address hidden>
Date: Thu Aug 21 17:37:07 2014 +1000

    Attribute variables for internal identity endpoint

    This patch adds the identity-internal-endpoints attributes to complment
    the first patch of this bug. As cookbook-openstack-identity now
    refences the identity-internal endpoint these variables are now
    required to be defined. As per convention endpoints are defined in this
    cookbook.

    Following this patch the number of node.set used in the registration
    tests can be reduced, as they will now have defaults defined here.
    Additionally a bump of the identity cookbook to rely on common 10.0.3
    will be required.
    Once this is done this bug can be closed.

    Change-Id: Iefca0b3df5b8efae94a661fc471c55a05cd8f64e
    Partial-Bug: #1356732

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/122319

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cookbook-openstack-identity (master)

Change abandoned by Sachi King (<email address hidden>) on branch: master
Review: https://review.openstack.org/117108
Reason: Version has been bumped by other additions, dropping this change.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cookbook-openstack-common (master)

Change abandoned by Sachi King (<email address hidden>) on branch: master
Review: https://review.openstack.org/122319

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-identity (master)

Fix proposed to branch: master
Review: https://review.openstack.org/127893

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-identity (master)

Reviewed: https://review.openstack.org/127893
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-identity/commit/?id=9f011b762b3f4178097956437be474768c6ed8c9
Submitter: Jenkins
Branch: master

commit 9f011b762b3f4178097956437be474768c6ed8c9
Author: Sachi King <email address hidden>
Date: Wed Aug 27 15:13:43 2014 +1000

    Add test to verify endpoints can be configured

    This patch updates the test suite to test that each endpoint can be
    configured independently of each other to ensure that the endpoints
    do not regress to multiple endpoints being configured by a single
    chef attribute.

    Change-Id: I6ebd78223bc580730e2d902141b5f84486998df7
    Closes-Bug: #1356732

Changed in openstack-chef:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.