[network] Add/check template tests

Bug #1328999 reported by Federico Gimenez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack + Chef
Fix Released
Wishlist
Federico Gimenez

Bug Description

We need chefspec tests to assert the contents of the templates. Ideally we need to test conditional logic is handled properly in the templates and default attribute values.

Changed in openstack-chef:
importance: Undecided → Wishlist
Changed in openstack-chef:
status: New → Incomplete
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-network (master)

Fix proposed to branch: master
Review: https://review.openstack.org/109048

Changed in openstack-chef:
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-network (master)

Reviewed: https://review.openstack.org/109048
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-network/commit/?id=cedf3540cf52e489c966fb8cebb5e57cd64ebeac
Submitter: Jenkins
Branch: master

commit cedf3540cf52e489c966fb8cebb5e57cd64ebeac
Author: Federico Gimenez Nieto <email address hidden>
Date: Wed Jul 23 19:20:36 2014 +0200

    Added missing tests and checked existing ones

    Partial-Bug: #1328999
    Implements: blueprint add-template-tests

    Change-Id: I19e49bde3d8dd9c195a0aee7f671c07428cce1a2

Changed in openstack-chef:
milestone: none → juno-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-network (master)

Fix proposed to branch: master
Review: https://review.openstack.org/118428

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-network (master)

Reviewed: https://review.openstack.org/118428
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-network/commit/?id=424ce1db2722605707e036360d371dcd9a5fae08
Submitter: Jenkins
Branch: master

commit 424ce1db2722605707e036360d371dcd9a5fae08
Author: Federico Gimenez Nieto <email address hidden>
Date: Tue Sep 23 14:50:46 2014 +0200

    Added missing template tests and checked existing ones (II)

    Covers lbaas_agent.ini.erb, metadata_agent.ini.erb, neutron.conf.erb,
    neutron-server.erb, neutron.sysconfig.erb and rootwrap.conf.erb
    Change-Id: Ie5c1bf67f57f4db554ba341d02732061a1f2c97c
    Partial-Bug: #1328999
    Implements: blueprint add-template-tests

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-network (master)

Fix proposed to branch: master
Review: https://review.openstack.org/127830

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-network (master)

Reviewed: https://review.openstack.org/127830
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-network/commit/?id=7865a50b363c16cf130e8c24c762e8b7b160ac6a
Submitter: Jenkins
Branch: master

commit 7865a50b363c16cf130e8c24c762e8b7b160ac6a
Author: Federico Gimenez Nieto <email address hidden>
Date: Sun Oct 12 13:24:02 2014 +0200

    Added missing template tests and checked existing ones (III)

    Covers all template plugins except midonet and metaplugin
    (see https://bugs.launchpad.net/bugs/1380243). Obvious mistakes
    have been corrected in some of the templates (trailing
    whitespaces, cut&pasted attribute names, instance variables
    instead of block variables and so on).

    Change-Id: I2302cd4f0ef29be4f1d783de930af2abbf7c1a15
    Closes-Bug: #1328999
    Implements: blueprint add-template-tests

Changed in openstack-chef:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.