[block-storage] Add/check template tests

Bug #1304412 reported by Federico Gimenez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack + Chef
Fix Released
Wishlist
Federico Gimenez

Bug Description

We need chefspec tests to assert the contents of the templates. Ideally we need to test conditional logic is handled properly in the templates and default attribute values.

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to cookbook-openstack-block-storage (master)

Fix proposed to branch: master
Review: https://review.openstack.org/89909

Changed in openstack-chef:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to cookbook-openstack-block-storage (master)

Reviewed: https://review.openstack.org/89909
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-block-storage/commit/?id=43a4e47717105f9eae40368a754ae0148f67887d
Submitter: Jenkins
Branch: master

commit 43a4e47717105f9eae40368a754ae0148f67887d
Author: Federico Gimenez Nieto <email address hidden>
Date: Thu Apr 24 08:26:55 2014 +0200

    Added/checked template tests

    Added inline stubs for endpoint, db_uri, rabbit_servers and
    get_password.
    In spec/cinder_common_spec.rb, the most complex template, there is a
    context for commonly named attributes, those which name matches a
    node attribute with keys ['openstack']['block-storage'][attr_key],
    storage_availability_zone for instance. This pattern is used in lots
    of configuration spec blocks, for example in
    ['openstack']['block-storage']['vmware'][attr_key].
    I've also found what appear to be some incongruences, like duplicated
    conditional checks for volume driver types and repeated storwize
    settings at the bottom. Perhaps these should be checked in another
    bug.
    Custom template banners have been added when needed.

    Change-Id: I4e90a602caea044d5415ca9b637d19d82f9ab227
    Closes-Bug: #1304412

Changed in openstack-chef:
status: In Progress → Fix Released
Changed in openstack-chef:
milestone: none → icehouse-rc1
importance: Undecided → Wishlist
Changed in openstack-chef:
milestone: icehouse-rc1 → icehouse-stable
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.