[common] Add template tests to cookbook

Bug #1300774 reported by Federico Gimenez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack + Chef
Fix Released
Low
Federico Gimenez

Bug Description

We need chefspec tests to assert the contents of the templates. Ideally we need to test conditional logic is handled properly in the templates and default attribute values.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/84818

Changed in openstack-chef:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-common (master)

Reviewed: https://review.openstack.org/84818
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-common/commit/?id=a69421e1c4e12f38be95422812c43e1922c5e7a0
Submitter: Jenkins
Branch: master

commit a69421e1c4e12f38be95422812c43e1922c5e7a0
Author: Federico Gimenez Nieto <email address hidden>
Date: Wed Apr 2 19:56:43 2014 +0200

    Added missing tests and checked existing ones

    Some of the tests have been modified to set the implied
    attributes to known values before verifying the
    expectations. The ceph.client.keyring.erb template has
    been deleted, any recipe was using it.

    Change-Id: Ic1e5c67015290f677628d2705474d192d1d2c6dc
    Closes-Bug: #1300774

Changed in openstack-chef:
status: In Progress → Fix Released
Changed in openstack-chef:
importance: Undecided → Medium
milestone: none → icehouse-rc1
importance: Medium → Low
Changed in openstack-chef:
milestone: icehouse-rc1 → icehouse-stable
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cookbook-openstack-common ocata-eol

This issue was fixed in the openstack/cookbook-openstack-common ocata-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.