Ubuntu node won't converge when default['openstack']['block-storage']['volume']['create_volume_group'] is true

[Matt Thompson]

When default['openstack']['block-storage']['volume']['create_volume_group'] is set to true, a script called cinder-group-active is dropped into /etc/init.d however this script is Red Hat specific. I'm currently working on an update to this script so it will also work on Ubuntu.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/70057

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/70057
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-block-storage/commit/?id=ad7da3d0cc52892b481e5454ba563cf56cf7083e
Submitter: Jenkins
Branch: master

commit ad7da3d0cc52892b481e5454ba563cf56cf7083e
Author: Matt Thompson <email address hidden>
Date: Thu Jan 30 13:30:12 2014 +0800

    Updates cinder-group-active script to work on Ubuntu

    Setting the following attribute to true causes a chef-client to fail on
    Ubuntu:

    default['openstack']['block-storage']['volume']['create_volume_group']

    The reason is that when this is enabled, the file cinder-group-active
    is dropped in /etc/init.d and attempting to start it fails since it's
    not written for Ubuntu. This change wraps some of the Red Hat specific
    bits with if statements and also conditionally runs the vgcreate so we
    don't run losetup unnecessarily (which keeps mapping the volume file to
    new /dev/loop devices).

    Change-Id: I5e14aeec64b1c1d596584bfc5d3352f45114421a
    Closes-Bug: #1274385