[compute] Add template tests to cookbook

[John Dewey]

We need chefspec tests to assert the contents of the templates. Ideally we only need to test conditional logic is handled properly in the templates.⋅

Currently they are marked as pending tests.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/82294

[Federico Gimenez (fgimenez)]

I've proposed a patch for this bug and in the review [1] it has been suggested that it was incomplete because it only addressed the compute cookbook.

Looking at the bug's title, description, tags and history it seems clear to me that it refers indeed to the compute cookbook, is that right?

If other cookbooks need also tests for the templates perhaps other bugs should be filed against them, what do you think?

[1] https://review.openstack.org/82294

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/82294
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-compute/commit/?id=998eb1bb04f6c5573ce3e357914e3c3ad098a22d
Submitter: Jenkins
Branch: master

commit 998eb1bb04f6c5573ce3e357914e3c3ad098a22d
Author: Federico Gimenez Nieto <email address hidden>
Date: Sat Mar 22 13:28:35 2014 +0100

    Adds specs for template contents

    Both conditional and plain content are tested. All template-related
    pending tests have been addressed, one in spec/compute_spec.rb that
    was tied to a cookbook_file resource has been just removed.

    Change-Id: Ib2d8871794920a10ad8e111fc89ab03ab057d3dc
    Partial-Bug: #1182563

[Justin Shepherd (jshepher)]

Marking as 'fix commited', the review was requested to be marked as Partial-Bug because there are a bunch of these types of fixes across the cookbooks. However, this bug is against the compute cookbook and that has been addressed with this proposed patch.

[Federico Gimenez (fgimenez)]

Great Justin, thanks a lot! I'll try to go on with the rest of the template tests. Do you think it's better to create a bug for each cookbook or just one for all of them?