browbeat scenarios fails with python-novaclient-18.3.0

[yatin]

With the recent release of novaclient(specifically with commit[1]), browbeat scenarios fails as below:-
Traceback (most recent call last):

  File "/home/stack/browbeat/.rally-venv/lib64/python3.9/site-packages/rally/task/runner.py", line 69, in _run_scenario_once
    getattr(scenario_inst, method_name)(**scenario_kwargs)
  File "rally/rally-plugins/netcreate-boot/netcreate_nova_boot_fip_ping.py", line 49, in run
    guest = self._boot_server_with_fip(image, flavor, True,
  File "/home/stack/browbeat/.rally-venv/lib64/python3.9/site-packages/rally_openstack/task/scenarios/vm/utils.py", line 144, in _boot_server_with_fip
    server = self._boot_server(image, flavor, **kwargs)
  File "/home/stack/browbeat/.rally-venv/lib64/python3.9/site-packages/rally_openstack/task/scenarios/nova/utils.py", line 103, in _boot_server
    server = self.clients("nova").servers.create(
TypeError: create() got an unexpected keyword argument 'floating'

Traceback (most recent call last):

  File "/home/stack/browbeat/.rally-venv/lib64/python3.9/site-packages/rally/task/runner.py", line 69, in _run_scenario_once
    getattr(scenario_inst, method_name)(**scenario_kwargs)
  File "rally/rally-plugins/dynamic-workloads/dynamic_workload_min.py", line 70, in run
    self.boot_servers_with_fip(smallest_image, smallest_flavor, ext_net_id,
  File "/home/stack/browbeat/rally/rally-plugins/dynamic-workloads/vm.py", line 102, in boot_servers_with_fip
    guest = self._boot_server_with_fip_and_tag(
  File "/home/stack/browbeat/rally/rally-plugins/dynamic-workloads/dynamic_utils.py", line 163, in _boot_server_with_fip_and_tag
    server = self._boot_server_with_tag(image, flavor, tag, **kwargs)
  File "/home/stack/browbeat/rally/rally-plugins/dynamic-workloads/dynamic_utils.py", line 148, in _boot_server_with_tag
    server = self._boot_server(image, flavor, auto_assign_nic, **kwargs)
  File "/home/stack/browbeat/.rally-venv/lib64/python3.9/site-packages/rally_openstack/task/scenarios/nova/utils.py", line 103, in _boot_server
    server = self.clients("nova").servers.create(
TypeError: create() got an unexpected keyword argument 'floating'

[1] https://github.com/openstack/python-novaclient/commit/80ee69aa30d36e941547a9b67668adfaf57355fd

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/x/browbeat/+/874928

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/x/browbeat/+/874987
Committed: https://opendev.org/x/browbeat/commit/d163c2a252b46fb0a718f8e14c1e30ac8c6c6621
Submitter: "Zuul (22348)"
Branch: master

commit d163c2a252b46fb0a718f8e14c1e30ac8c6c6621
Author: Sanjay Chari <email address hidden>
Date: Fri Feb 24 13:39:27 2023 +0530

    Pin python-novaclient to 17.6.0

    rally-openstack has an upper constraint of 17.6.0
    for python-novaclient. Browbeat requires this constraint
    too as multiple scenarios are failing because of
    breaking changes in python-novaclient version 18.3.0.

    Closes-Bug: #2008235
    Change-Id: I25b6561413217a875e3c9270ae0b8057ac15f352

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/x/browbeat/+/874928
Committed: https://opendev.org/x/browbeat/commit/ba485b728dc5cd70529290f64ef17d0f42414f08
Submitter: "Zuul (22348)"
Branch: master

commit ba485b728dc5cd70529290f64ef17d0f42414f08
Author: yatinkarel <email address hidden>
Date: Thu Feb 23 20:19:43 2023 +0530

    Pin python-novaclient to 17.6.0

    With[1] included in novaclient-18.3.0 use of
    floating and other keyword args do not work.
    Until browbeat code base is compatible with
    novaclient-18.3.0, let's pin it.

    It is follow up of [2] as that was not sufficient.

    [1] https://github.com/openstack/python-novaclient/commit/80ee69a
    [2] https://review.opendev.org/c/x/browbeat/+/874987

    Closes-Bug: #2008235
    Change-Id: I9d89c15cd2b67d7801ed197caa40d37f1901612c

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/x/browbeat/+/875509

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/x/browbeat/+/875509
Committed: https://opendev.org/x/browbeat/commit/8a7b2439730d1a6957261fd0b82e60107f44136a
Submitter: "Zuul (22348)"
Branch: master

commit 8a7b2439730d1a6957261fd0b82e60107f44136a
Author: yatinkarel <email address hidden>
Date: Mon Feb 27 21:11:22 2023 +0530

    Fix pin of novaclient to working version

    Previous pin[1] didn't worked as it conflicted
    with version requirements from openstackclient

    This patch pins novaclient to last known good
    version.

    [1] https://review.opendev.org/c/x/browbeat/+/874928

    Closes-Bug: #2008235
    Change-Id: I446f6348fbfc8becfe3fa047b09cb320d2ed143f