Security group update API missing in nova and neutron API docs

Bug #1463131 reported by David Shrewsbury
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-api-site
Fix Released
Medium
Diane Fleming

Bug Description

Neither the Nova API docs:

    http://developer.openstack.org/api-ref-compute-v2-ext.html#os-security-groups

nor the Neutron API docs:

   http://developer.openstack.org/api-ref-networking-v2-ext.html#security_groups

Show the API for *updating* a security group. Both the neutron and nova CLI's
have commands for updating a sec group (and they both work), so the docs must
be incorrect here.

Revision history for this message
Anne Gentle (annegentle) wrote :

It's possible there's no "update" command in the API and the client is issuing "DELETE" then "POST" commands. The way to find out is to do: nova --debug secgroup-update <secgroup> <name> <description> and you can see all the API commands go. Do that and let me know what you find out. I'm trying myself with my various cloud accounts but so far I don't have one where the policy lets me do this.

Changed in openstack-api-site:
status: New → Incomplete
Revision history for this message
David Shrewsbury (dshrews) wrote :

Thanks Anne. It's definitely a PUT for the update, and there is definitely an update command in the API:

   https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/security_groups.py#L51

which eventually calls self.api.client.put() here:

   https://github.com/openstack/python-novaclient/blob/master/novaclient/base.py#L174

FYI, this was tested on HP Cloud. Debug output showed no DELETE, only PUT:

DEBUG (session:195) REQ: curl -g -i -X PUT https://region-b.geo-1.compute.hpcloudsvc.com/v2/55017136973364/os-security-groups/GROUPID -H "User-Agent: python-novaclient" -H "Content-Type: application/json" -H "Accept: application/json" -H "X-Auth-Token: {SHA1}ABC123" -d '{"security_group": {"name": "devel", "description": "Devel group"}}'

Revision history for this message
Tom Fifield (fifieldt) wrote :

was looking for this too.

Changed in openstack-api-site:
status: Incomplete → Confirmed
importance: Undecided → Medium
Changed in openstack-api-site:
assignee: nobody → Diane Fleming (diane-fleming)
milestone: none → liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to api-site (master)

Fix proposed to branch: master
Review: https://review.openstack.org/220569

Changed in openstack-api-site:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to api-site (master)

Reviewed: https://review.openstack.org/220569
Committed: https://git.openstack.org/cgit/openstack/api-site/commit/?id=73fbcef0394f8a22b342dc670899c0984d5d4c34
Submitter: Jenkins
Branch: master

commit 73fbcef0394f8a22b342dc670899c0984d5d4c34
Author: Diane Fleming <email address hidden>
Date: Fri Sep 4 11:07:47 2015 -0500

    Add "update security group" to Compute v2 and Networking v2

    Change-Id: I4ff45c7a998b1c0048e23e058f4ce15a3136287b
    Closes-Bug: #1463131

Changed in openstack-api-site:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.