os-interface create API docs are wrong

[Matt Riedemann]

Was looking at bug 1338551 and the API docs for the attach_interface create method:

http://docs.openstack.org/api/openstack-compute/2/content/POST_os-interface-v2_createAttachInterface__v2__tenant_id__servers__server_id__os-interface_ext-os-interface.html

The API docs say that port_id is required in the request but it's actually optional:

http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/contrib/attach_interfaces.py#n80

You can send in port_id/net_id/fixed_ips, net_id and port_id are mutually exclusive, and requesting a specific fixed_ip without a net_id is a 400 BadRequest also.

If the port_id isn't provided, the network API will allocate one on the given network. If net_id isn't provided, the network associated with the instance in the network info cache will be used.

The API docs also don't list any error codes, of which there are 400, 404, 409, 500, and 501 (because nova-network doesn't implement this API).

[Anne Gentle (annegentle)]

Agreed, you can move out of nova if needed, we'll fix in the api-site.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/172761

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/172761
Committed: https://git.openstack.org/cgit/openstack/api-site/commit/?id=86b3d06d0e38134b88518cebf544af389a9c84df
Submitter: Jenkins
Branch: master

commit 86b3d06d0e38134b88518cebf544af389a9c84df
Author: Diane Fleming <email address hidden>
Date: Sun Apr 12 17:31:10 2015 -0500

    Update request parameters for os-interfaces extension

    Add return codes.

    Change-Id: I4693b20143e17927a04edf70de81a881c6d5f524
    Closes-Bug: #1352950