Ceilometer Configurations Not Being Set on Cinder API Containers

Bug #1654038 reported by Sean Carlisle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Medium
Andy McCrae
Mitaka
Fix Released
Undecided
Andy McCrae

Bug Description

When setting cinder_ceilometer_enabled to True in /etc/openstack_deploy/user_variables.yml, the necessary configurations are not added to cinder.conf for the Cinder API containers on subsequent playbook runs, only on Cinder storage nodes. This affects the stable/mitaka branch for openstack-ansible-os_cinder for commit b41c588 and prior.

This is caused by a logical error in the cinder.conf.j2 template file:

...
{% if cinder_backends is defined %}
enabled_backends={% for backend in cinder_backends|dictsort %}{{ backend.0 }}{% if not loop.last %},{% endif %}{% endfor %}

{% if cinder_ceilometer_enabled %}
[oslo_messaging_notifications]
driver = messagingv2
{% endif %}

# All given backend(s)
{% for backend_section in cinder_backends|dictsort %}
[{{ backend_section.0 }}]
{% for key, value in backend_section.1.items() %}
{{ key }}={{ value }}
{% endfor %}
{% if cinder_nfs_client is defined %}
nfs_shares_config={{ cinder_nfs_client.nfs_shares_config }}
{% endif %}

{% endfor %}
{% endif %}
...

As you can see, the oslo_messaging_notifications section only gets set for nodes where cinder_backends is defined. This bug appears to be fixed in stable/newton, but I could find no bug report for the problem itself. I'm filing the bug in the hopes that the fix can be back-ported to Mitaka.

Thank you.

Changed in openstack-ansible:
status: New → Confirmed
importance: Undecided → Medium
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_cinder (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/418471

Changed in openstack-ansible:
assignee: nobody → Andy McCrae (andrew-mccrae)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_cinder (stable/mitaka)

Reviewed: https://review.openstack.org/418471
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_cinder/commit/?id=cb20d214dfb29f2c7ec14daf3dbfbc31e69f9ce8
Submitter: Jenkins
Branch: stable/mitaka

commit cb20d214dfb29f2c7ec14daf3dbfbc31e69f9ce8
Author: Andy McCrae <email address hidden>
Date: Tue Jan 10 16:22:57 2017 +0000

    Fix ceilometer logic in cinder.conf

    This logic was fixed in the Newton time frame as part of
    Ia2f906af5d98c98ffcdbc07ab88ee7b0993eeb8c
    The fix to the ceilometer was not backported, this patch simply fixes
    the logic failing for the Ceilometer configuration inside cinder.conf,
    and ensures that the Ceilometer configuration is setup regardless of
    whether the host is a storage or api cinder host.

    Change-Id: I76797470065272ba72d10bfddebb327ad02b5dcd
    Closes-Bug: #1654038

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible-os_cinder 13.3.13

This issue was fixed in the openstack/openstack-ansible-os_cinder 13.3.13 release.

Changed in openstack-ansible:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.