os_swift_sync role does not support weight changes

Bug #1532204 reported by Bjoern
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Medium
matthewoliver
Kilo
Won't Fix
Medium
Unassigned
Liberty
Fix Released
Medium
Jesse Pretorius
Trunk
Fix Released
Medium
matthewoliver

Bug Description

When updating weights for certain nodes, the os_swift_sync role will fail with:

TASK: [os_swift_sync | Ensure contents file matches ring after ring sync for account/container] ***

failed: [objectstorage002] => (item=account) => {"changed": true, "cmd": ["/usr/bin/python", "/etc/swift/scripts/swift_rings_check.py", "-f", "/etc/swift/scripts/account.contents"], "delta": "0:00:00.067582", "end": "2016-01-07 14:13:58.254629", "item": "account", "rc": 2, "start": "2016-01-07 14:13:58.187047", "warnings": []}
stdout: Device weight for device <ip>:6002/disk11 differs to the ring.

The respective rings were still showing the old weight of the object servers, when this error happened

There were no other ring operations happening.

Revision history for this message
Bjoern (bjoern-t) wrote :

Fix submitted for master : https://review.openstack.org/#/c/265044

description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (master)

Reviewed: https://review.openstack.org/265044
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=1f45a2736a7dfc95b2f57a0bf2c0762ab2df9d5a
Submitter: Jenkins
Branch: master

commit 1f45a2736a7dfc95b2f57a0bf2c0762ab2df9d5a
Author: Matthew Oliver <email address hidden>
Date: Fri Jan 8 13:06:22 2016 +1100

    Fix os_swift_sync role's set_weight

    The swift_rings.py file that updates the swift ring files are
    failing to update the weight in a builder file. This is caused
    by the weight passed into the swift-ring-builder CLI needing
    to be a string.

    This patch converts the weight to a string when passing it to
    swift-ring-builder.

    Closes-Bug: #1532204
    Change-Id: Iceb3f19eb226fdcfd373fa73d8a5d41b41a239af

Changed in openstack-ansible:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (liberty)

Fix proposed to branch: liberty
Review: https://review.openstack.org/265839

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (liberty)

Reviewed: https://review.openstack.org/265839
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=b8960180140cc56f48e2ae87f386016a8204a4ac
Submitter: Jenkins
Branch: liberty

commit b8960180140cc56f48e2ae87f386016a8204a4ac
Author: Matthew Oliver <email address hidden>
Date: Fri Jan 8 13:06:22 2016 +1100

    Fix os_swift_sync role's set_weight

    The swift_rings.py file that updates the swift ring files are
    failing to update the weight in a builder file. This is caused
    by the weight passed into the swift-ring-builder CLI needing
    to be a string.

    This patch converts the weight to a string when passing it to
    swift-ring-builder.

    Closes-Bug: #1532204
    Change-Id: Iceb3f19eb226fdcfd373fa73d8a5d41b41a239af
    (cherry picked from commit 1f45a2736a7dfc95b2f57a0bf2c0762ab2df9d5a)

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 12.0.8

This issue was fixed in the openstack/openstack-ansible 12.0.8 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 12.0.9

This issue was fixed in the openstack/openstack-ansible 12.0.9 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 13.0.0

This issue was fixed in the openstack/openstack-ansible 13.0.0 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

This issue was fixed in the openstack/openstack-ansible 13.0.0 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 12.0.11

This issue was fixed in the openstack/openstack-ansible 12.0.11 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.