Ansible templating of swift.conf breaks swift-recon on a multi-region deployment

Bug #1589532 reported by git-harry
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Major Hayden
Kilo
Fix Released
Undecided
Darren Birkett
Liberty
Fix Released
Undecided
Darren Birkett
Mitaka
Fix Released
Undecided
Jean-Philippe Evrard
Trunk
Fix Released
Undecided
Major Hayden

Bug Description

What is the expected behaviour?

swift.conf should match throughout the environment. swift-recon --md5 should pass without errors.

What is actually happening?

ansible template in adding "# Ansible managed:" at the top thus causing:

`(swift-12.0.13)root@XXXXX-swiftproxy001_swift_proxy_container-ACBDEFG:~# swift-recon --md5
===============================================================================
--> Starting reconnaissance on 42 hosts
===============================================================================
[2016-06-02 09:29:58] Checking ring md5sums
42/42 hosts matched, 0 error[s] while checking hosts.
===============================================================================
[2016-06-02 09:29:58] Checking swift.conf md5sum
!! http://172.28.244.107:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.100:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.114:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.116:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.106:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.115:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.104:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.110:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.117:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.105:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.103:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.111:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.118:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.109:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.102:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.112:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.119:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.120:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.108:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.101:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
!! http://172.28.244.113:6000/recon/swiftconfmd5 (c1e92abe9bef64173049c0ea87267898) doesn't match on disk md5sum
21/42 hosts matched, 0 error[s] while checking hosts.
==============================================================================
How can we reproduce this issue?

Install multi-region Swift and run 'swift-recon --md5'.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/326369

Changed in openstack-ansible:
assignee: nobody → Darren Birkett (darren-birkett)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (liberty)

Fix proposed to branch: liberty
Review: https://review.openstack.org/326374

Changed in openstack-ansible:
assignee: Darren Birkett (darren-birkett) → Major Hayden (rackerhacker)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_swift (master)

Reviewed: https://review.openstack.org/326369
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_swift/commit/?id=2dc3514da59eaaf683166cb30ef9ab2a9bc83363
Submitter: Jenkins
Branch: master

commit 2dc3514da59eaaf683166cb30ef9ab2a9bc83363
Author: Darren Birkett <email address hidden>
Date: Tue Jun 7 11:31:46 2016 +0100

    Make ansible managed line in swift.conf static

    The ansible-managed line includes date/time information, meaning that
    the conf file that gets laid down on different hosts does not have the
    same MD5 sum across all hosts. This causes swift-recon --md5 to fail.

    This commit fixes the issue by adding a static comment
    to the config file instead

    Change-Id: Id00cd79636f43776aaaa51e2ae6d7c5eacff8d34
    Partial-Bug: #1589532

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_swift (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/328393

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_swift (stable/mitaka)

Reviewed: https://review.openstack.org/328393
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-os_swift/commit/?id=fb102b51dae7fe75822314ec8ed8c8fde52c008a
Submitter: Jenkins
Branch: stable/mitaka

commit fb102b51dae7fe75822314ec8ed8c8fde52c008a
Author: Darren Birkett <email address hidden>
Date: Tue Jun 7 11:31:46 2016 +0100

    Make ansible managed line in swift.conf static

    The ansible-managed line includes date/time information, meaning that
    the conf file that gets laid down on different hosts does not have the
    same MD5 sum across all hosts. This causes swift-recon --md5 to fail.

    This commit fixes the issue by adding a static comment
    to the config file instead

    Change-Id: Id00cd79636f43776aaaa51e2ae6d7c5eacff8d34
    Partial-Bug: #1589532
    (cherry picked from commit 2dc3514da59eaaf683166cb30ef9ab2a9bc83363)

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (liberty)

Reviewed: https://review.openstack.org/326374
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=b3777c507b602ca9d44728e169e58e4811dda9bf
Submitter: Jenkins
Branch: liberty

commit b3777c507b602ca9d44728e169e58e4811dda9bf
Author: Darren Birkett <email address hidden>
Date: Tue Jun 7 11:38:18 2016 +0100

    Make ansible managed line in swift.conf static

    The ansible-managed line includes date/time information, meaning that
    the conf file that gets laid down on different hosts does not have the
    same MD5 sum across all hosts. This causes swift-recon --md5 to fail.

    This commit fixes the issue by adding a static comment
    to the config file instead

    Change-Id: Id00cd79636f43776aaaa51e2ae6d7c5eacff8d34
    Partial-Bug: #1589532

tags: added: in-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (kilo)

Fix proposed to branch: kilo
Review: https://review.openstack.org/332011

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (kilo)

Reviewed: https://review.openstack.org/332011
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=6df4ba80861b59198383dce932204f63d22c639e
Submitter: Jenkins
Branch: kilo

commit 6df4ba80861b59198383dce932204f63d22c639e
Author: Darren Birkett <email address hidden>
Date: Tue Jun 7 11:38:18 2016 +0100

    Make ansible managed line in swift.conf static

    The ansible-managed line includes date/time information, meaning that
    the conf file that gets laid down on different hosts does not have the
    same MD5 sum across all hosts. This causes swift-recon --md5 to fail.

    This commit fixes the issue by adding a static comment
    to the config file instead

    Change-Id: Id00cd79636f43776aaaa51e2ae6d7c5eacff8d34
    Partial-Bug: #1589532
    (cherry picked from commit b3777c507b602ca9d44728e169e58e4811dda9bf)

tags: added: in-kilo
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.