OSA Trove Guest Agent Conf Template Bug

Bug #2056663 reported by James Black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Unassigned

Bug Description

It looks like trove.conf.j2 got updated recently for Rabbit QQs but guest agent did not

BUG:

trove-guestagent.conf.j2

Current:

[DEFAULT]
transport_url = "{{ trove_oslomsg_rpc_transport }}://{% for host in trove_guest_oslomsg_rpc_servers.split(',') %}{{ trove_oslomsg_rpc_userid }}:{{ trove_oslomsg_rpc_password }}@{{ host }}:{{ trove_oslomsg_rpc_port }}{% if not loop.last %},{% else %}/{{ trove_oslomsg_rpc_vhost }}{% if trove_oslomsg_rpc_use_ssl | bool %}?ssl=1&ssl_version={{ trove_oslomsg_rpc_ssl_version }}&ssl_ca_file={{ trove_oslomsg_rpc_ssl_ca_file }}{% else %}?ssl=0{% endif %}{% endif %}{% endfor %}"

[oslo_messaging_notifications]
transport_url = "{{ trove_oslomsg_notify_transport }}://{% for host in trove_guest_oslomsg_notify_servers.split(',') %}{{ trove_oslomsg_notify_userid }}:{{ trove_oslomsg_notify_password }}@{{ host }}:{{ trove_oslomsg_notify_port }}{% if not loop.last %},{% else %}/{{ trove_oslomsg_notify_vhost }}{% endif %}{% endfor %}"

List gets templated, not vhost type.

Gives:
transport_url = rabbit://trove:password@172.29.217.6:5671,trove:password@172.29.217.194:5671,trove:password@172.29.218.204:5671/[{'name': '/trove', 'state': 'absent'}, {'name': 'trove', 'state': 'present'}]

Fix:

Should be:
[DEFAULT]
transport_url = "{{ trove_oslomsg_rpc_transport }}://{% for host in trove_guest_oslomsg_rpc_servers.split(',') %}{{ trove_oslomsg_rpc_userid }}:{{ trove_oslomsg_rpc_password }}@{{ host }}:{{ trove_oslomsg_rpc_port }}{% if not loop.last %},{% else %}/{{ _trove_oslomsg_rpc_vhost_conf }}{% if trove_oslomsg_rpc_use_ssl | bool %}?ssl=1&ssl_version={{ trove_oslomsg_rpc_ssl_version }}&ssl_ca_file={{ trove_oslomsg_rpc_ssl_ca_file }}{% else %}?ssl=0{% endif %}{% endif %}{% endfor %}"

[oslo_messaging_notifications]
transport_url = "{{ trove_oslomsg_notify_transport }}://{% for host in trove_guest_oslomsg_notify_servers.split(',') %}{{ trove_oslomsg_notify_userid }}:{{ trove_oslomsg_notify_password }}@{{ host }}:{{ trove_oslomsg_notify_port }}{% if not loop.last %},{% else %}/{{ _trove_oslomsg_notify_vhost_conf }}{% if trove_oslomsg_notify_use_ssl | bool %}?ssl=1&ssl_version={{ trove_oslomsg_notify_ssl_version }}&ssl_ca_file={{ trove_oslomsg_notify_ssl_ca_file }}{% else %}?ssl=0{% endif %}{% endif %}{% endfor %}"

Gives:

transport_url = rabbit://trove:password@172.29.231.202:5671,trove:password@172.29.231.165:5671,trove:password@172.29.229.203:5671/trove?ssl=1&ssl_version=TLSv1_2&ssl_ca_file=

James Black (hamburgler)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_trove (master)
Changed in openstack-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to openstack-ansible-os_trove (master)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to openstack-ansible-os_trove (master)

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/917025
Committed: https://opendev.org/openstack/openstack-ansible-os_trove/commit/ad2f04fbe03d0e61557d8c9c32363325c1196612
Submitter: "Zuul (22348)"
Branch: master

commit ad2f04fbe03d0e61557d8c9c32363325c1196612
Author: Dmitriy Rabotyagov <email address hidden>
Date: Thu Apr 25 13:13:34 2024 +0200

    Add TLS configuration for guestagent notifications

    While adding TLS support for RabbitMQ it was missed to configure
    notifications for Trove guestagent.

    Related-Bug: #2056663
    Change-Id: Iad29d9f4f344861e3fa9a959c2c03d5a3f87c430

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_trove (master)

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/917024
Committed: https://opendev.org/openstack/openstack-ansible-os_trove/commit/110feb6128df34070872cb4f2fea6fab1cdc0496
Submitter: "Zuul (22348)"
Branch: master

commit 110feb6128df34070872cb4f2fea6fab1cdc0496
Author: Dmitriy Rabotyagov <email address hidden>
Date: Thu Apr 25 13:07:59 2024 +0200

    Fix RabbitMQ vhost defenition for guestagent

    While adding support for quorum queues it was missed to reflect changes
    for guestagent settings, which leads to invalid configuration

    Closes-Bug: #2056663
    Change-Id: Id8a428686287ec4067c5eeec12d65329d0248669

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to openstack-ansible-os_trove (stable/2023.2)

Related fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/917890

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to openstack-ansible-os_trove (stable/2023.1)

Related fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/917891

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_trove (stable/2023.1)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-os_trove (stable/2023.2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on openstack-ansible-os_trove (stable/2023.1)

Change abandoned by "Dmitriy Rabotyagov <email address hidden>" on branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/917988
Reason: this one is not needed on 2023.1 as quorum queues were not there yet

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to openstack-ansible-os_trove (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/917890
Committed: https://opendev.org/openstack/openstack-ansible-os_trove/commit/40e374ef1c450bbdd7eb75eaeb9eed2d9f31ad82
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 40e374ef1c450bbdd7eb75eaeb9eed2d9f31ad82
Author: Dmitriy Rabotyagov <email address hidden>
Date: Thu Apr 25 13:13:34 2024 +0200

    Add TLS configuration for guestagent notifications

    While adding TLS support for RabbitMQ it was missed to configure
    notifications for Trove guestagent.

    Related-Bug: #2056663
    Change-Id: Iad29d9f4f344861e3fa9a959c2c03d5a3f87c430
    (cherry picked from commit ad2f04fbe03d0e61557d8c9c32363325c1196612)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-os_trove (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/917989
Committed: https://opendev.org/openstack/openstack-ansible-os_trove/commit/e0d59b3e0c1232f7362df3f25ea9b3b558045119
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit e0d59b3e0c1232f7362df3f25ea9b3b558045119
Author: Dmitriy Rabotyagov <email address hidden>
Date: Thu Apr 25 13:07:59 2024 +0200

    Fix RabbitMQ vhost defenition for guestagent

    While adding support for quorum queues it was missed to reflect changes
    for guestagent settings, which leads to invalid configuration

    Closes-Bug: #2056663
    Change-Id: Id8a428686287ec4067c5eeec12d65329d0248669

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to openstack-ansible-os_trove (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible-os_trove/+/917891
Committed: https://opendev.org/openstack/openstack-ansible-os_trove/commit/d162ab5ebd66a92dfd5992e32181795c6a88e3b2
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit d162ab5ebd66a92dfd5992e32181795c6a88e3b2
Author: Dmitriy Rabotyagov <email address hidden>
Date: Thu Apr 25 13:13:34 2024 +0200

    Add TLS configuration for guestagent notifications

    While adding TLS support for RabbitMQ it was missed to configure
    notifications for Trove guestagent.

    Related-Bug: #2056663
    Change-Id: Iad29d9f4f344861e3fa9a959c2c03d5a3f87c430
    (cherry picked from commit ad2f04fbe03d0e61557d8c9c32363325c1196612)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.