haproxy httpcheck for nova spice console has typo

Bug #2052891 reported by Cees Moerkerken
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Undecided
Unassigned

Bug Description

The httpcheck_options is missing a space before meth causing haproxy to fail on the config validation.

in openstack-ansible/inventory/group_vars/nova_all/haproxy_service.yml

it is now:
  haproxy_backend_httpcheck_options: "{{ haproxy_nova_console_http_mode | ternary(['send ' ~ haproxy_nova_healthcheck_hdr ~ 'meth HEAD uri /spice_auto.html', 'expect status 200'], []) }}"

and should be:
  haproxy_backend_httpcheck_options: "{{ haproxy_nova_console_http_mode | ternary(['send ' ~ haproxy_nova_healthcheck_hdr ~ ' meth HEAD uri /spice_auto.html', 'expect status 200'], []) }}"

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (master)
Changed in openstack-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/908746
Committed: https://opendev.org/openstack/openstack-ansible/commit/76bb370450d4e67c1275eac686491d22da8061a3
Submitter: "Zuul (22348)"
Branch: master

commit 76bb370450d4e67c1275eac686491d22da8061a3
Author: Dmitriy Rabotyagov <email address hidden>
Date: Sun Feb 11 17:17:24 2024 +0100

    Fix formatting issue for SPICE HAProxy httpcheck

    Due to the issue in formatting healthcheck address was merged with meth
    which resulted in invalid haproxy configuration, when SPICE is being used
    as a console.

    Closes-Bug: #2052891
    Change-Id: I38b2ff6887382164e4b28852274ec6dfee4d7d78

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/openstack-ansible/+/908922

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/openstack-ansible/+/908922
Committed: https://opendev.org/openstack/openstack-ansible/commit/5c588c45ab354375f3b0e660638ecf4dd744d735
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 5c588c45ab354375f3b0e660638ecf4dd744d735
Author: Dmitriy Rabotyagov <email address hidden>
Date: Sun Feb 11 17:17:24 2024 +0100

    Fix formatting issue for SPICE HAProxy httpcheck

    Due to the issue in formatting healthcheck address was merged with meth
    which resulted in invalid haproxy configuration, when SPICE is being used
    as a console.

    Closes-Bug: #2052891
    Change-Id: I38b2ff6887382164e4b28852274ec6dfee4d7d78
    (cherry picked from commit 76bb370450d4e67c1275eac686491d22da8061a3)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-ansible 28.1.0

This issue was fixed in the openstack/openstack-ansible 28.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.